Added tests; updates from PR feedback.

Author: chris-nissen

src/GraphQL.Authorization.Tests/AuthorizationValidationRuleTests.cs

@@ -15,7 +15,7 @@ public void class_policy_success()
                 _.RequireClaim("admin");
             });
 
-            ShouldPassRule(_=>
+            ShouldPassRule(_ =>
             {
                 _.Query = @"query { post }";
                 _.Schema = BasicSchema();
@@ -34,7 +34,7 @@ public void class_policy_fail()
                 _.RequireClaim("admin");
             });
 
-            ShouldFailRule(_=>
+            ShouldFailRule(_ =>
             {
                 _.Query = @"query { post }";
                 _.Schema = BasicSchema();
@@ -49,7 +49,7 @@ public void field_policy_success()
                 _.RequireClaim("admin");
             });
 
-            ShouldPassRule(_=>
+            ShouldPassRule(_ =>
             {
                 _.Query = @"query { post }";
                 _.Schema = BasicSchema();
@@ -68,7 +68,7 @@ public void field_policy_fail()
                 _.RequireClaim("admin");
             });
 
-            ShouldFailRule(_=>
+            ShouldFailRule(_ =>
             {
                 _.Query = @"query { post }";
                 _.Schema = BasicSchema();
@@ -83,7 +83,7 @@ public void nested_type_policy_success()
                 _.RequireClaim("admin");
             });
 
-            ShouldPassRule(_=>
+            ShouldPassRule(_ =>
             {
                 _.Query = @"query { post }";
                 _.Schema = NestedSchema();
@@ -102,7 +102,7 @@ public void nested_type_policy_fail()
                 _.RequireClaim("admin");
             });
 
-            ShouldFailRule(_=>
+            ShouldFailRule(_ =>
             {
                 _.Query = @"query { post }";
                 _.Schema = NestedSchema();
@@ -117,7 +117,7 @@ public void passes_with_claim_on_input_type()
                 _.RequireClaim("admin");
             });
 
-            ShouldPassRule(_=>
+            ShouldPassRule(_ =>
             {
                 _.Query = @"query { author(input: { name: ""Quinn"" }) }";
                 _.Schema = TypedSchema();
@@ -136,13 +136,72 @@ public void fails_on_missing_claim_on_input_type()
                 _.RequireClaim("admin");
             });
 
-            ShouldFailRule(_=>
+            ShouldFailRule(_ =>
             {
                 _.Query = @"query { author(input: { name: ""Quinn"" }) }";
                 _.Schema = TypedSchema();
             });
         }
 
+        [Fact]
+        public void passes_when_field_is_not_included()
+        {
+            Settings.AddPolicy("FieldPolicy", _ =>
+            {
+                _.RequireClaim("admin");
+            });
+
+            ShouldPassRule(_ =>
+            {
+                _.Query = @"query { post @include(if: false) }";
+                _.Schema = BasicSchema();
+            });
+        }
+        [Fact]
+        public void fails_when_field_is_included()
+        {
+            Settings.AddPolicy("FieldPolicy", _ =>
+            {
+                _.RequireClaim("admin");
+            });
+
+            ShouldFailRule(_ =>
+            {
+                _.Query = @"query { post @include(if: true) }";
+                _.Schema = BasicSchema();
+            });
+        }
+
+        [Fact]
+        public void passes_when_field_is_skipped()
+        {
+            Settings.AddPolicy("FieldPolicy", _ =>
+            {
+                _.RequireClaim("admin");
+            });
+
+            ShouldPassRule(_ =>
+            {
+                _.Query = @"query { post @skip(if: true) }";
+                _.Schema = BasicSchema();
+            });
+        }
+
+        [Fact]
+        public void fails_when_field_is_not_skipped()
+        {
+            Settings.AddPolicy("FieldPolicy", _ =>
+            {
+                _.RequireClaim("admin");
+            });
+
+            ShouldFailRule(_ =>
+            {
+                _.Query = @"query { post @skip(if: false) }";
+                _.Schema = BasicSchema();
+            });
+        }
+
         private ISchema BasicSchema()
         {
             var defs = @"
@@ -204,7 +263,7 @@ public class Post
 
         public class Author
         {
-            public string Name { get; set;}
+            public string Name { get; set; }
         }
 
         private ISchema TypedSchema()

src/GraphQL.Authorization/AuthorizationValidationRule.cs

@@ -62,28 +62,31 @@ public INodeVisitor Validate(ValidationContext context)
 
         private bool SkipAuthCheck(Field fieldAst, ValidationContext context)
         {
-            if (fieldAst.Directives == null || !fieldAst.Directives.Any()) return true;
+            if (fieldAst.Directives == null || !fieldAst.Directives.Any()) return false;
 
-            var includeField = GetDirectiveValue(context, fieldAst.Directives, DirectiveGraphType.Include.Name);
+            var includeField = GetDirectiveValue(context, fieldAst.Directives, DirectiveGraphType.Include);
             if (includeField.HasValue) return !includeField.Value;
 
-            var skipField = GetDirectiveValue(context, fieldAst.Directives, DirectiveGraphType.Skip.Name);
+            var skipField = GetDirectiveValue(context, fieldAst.Directives, DirectiveGraphType.Skip);
             if (skipField.HasValue) return skipField.Value;
 
             return false;
         }
 
-        private static bool? GetDirectiveValue(ValidationContext context, Directives directives, string directiveName)
+        private static bool? GetDirectiveValue(ValidationContext context, Directives directives, DirectiveGraphType directiveType)
         {
-            var directive = directives.Find(directiveName);
+            var directive = directives.Find(directiveType.Name);
             if (directive == null) return null;
 
-            var operation = !string.IsNullOrWhiteSpace(context.OperationName)
-                ? context.Document.Operations.WithName(context.OperationName)
-                : context.Document.Operations.FirstOrDefault();
+            var operationName = context.OperationName;
+            var documentOperations = context.Document.Operations;
+            var operation = !string.IsNullOrWhiteSpace(operationName)
+                ? documentOperations.WithName(operationName)
+                : documentOperations.FirstOrDefault();
+
             var values = ExecutionHelper.GetArgumentValues(
                 context.Schema,
-                DirectiveGraphType.Include.Arguments,
+                directiveType.Arguments,
                 directive.Arguments,
                 ExecutionHelper.GetVariableValues(context.Document, context.Schema, operation?.Variables, context.Inputs));