fix(Flowtype): more strict type checks

Author: nodkz

.eslintrc

@@ -36,6 +36,7 @@
   "globals": {
     "Class": true,
     "$Shape": true,
+    "$FlowFixMe": true,
   },
   "plugins": [
     "flowtype",

src/__tests__/composeWithRelay-test.js

@@ -24,8 +24,9 @@ describe('composeWithRelay', () => {
     });
 
     it('should throw error if got a not TypeComposer', () => {
-      // $FlowFixMe
-      expect(() => composeWithRelay(123)).toThrowError('should provide TypeComposer instance');
+      expect(() => composeWithRelay((123: any))).toThrowError(
+        'should provide TypeComposer instance'
+      );
     });
 
     it('should throw error if TypeComposer without recordIdFn', () => {
@@ -45,9 +46,8 @@ describe('composeWithRelay', () => {
 
   describe('when pass RootQuery type composer', () => {
     it('should add `node` field to RootQuery', () => {
-      const nodeField = rootQueryComposer.getField('node');
+      const nodeField: any = rootQueryComposer.getField('node');
       expect(nodeField.type).toBeInstanceOf(GraphQLInterfaceType);
-      // $FlowFixMe
       expect(nodeField.type.name).toBe('Node');
     });
   });
@@ -77,10 +77,8 @@ describe('composeWithRelay', () => {
           name
         }
       }`;
-      const result = await graphql(schema, query);
-      // $FlowFixMe
+      const result: any = await graphql(schema, query);
       expect(result.data.user.id).toBe(toGlobalId('User', 1));
-      // $FlowFixMe
       expect(result.data.user.name).toBe('Pavel');
     });
 
@@ -101,10 +99,8 @@ describe('composeWithRelay', () => {
         id
         name
       }`;
-      const result = await graphql(schema, query);
-      // $FlowFixMe
+      const result: any = await graphql(schema, query);
       expect(result.data.node.id).toBe(toGlobalId('User', 1));
-      // $FlowFixMe
       expect(result.data.node.name).toBe('Pavel');
     });
 
@@ -125,10 +121,8 @@ describe('composeWithRelay', () => {
           clientMutationId
         }
       }`;
-      const result = await graphql(schema, query);
-      // $FlowFixMe
+      const result: any = await graphql(schema, query);
       expect(result.data.createUser.record.name).toBe('Ok');
-      // $FlowFixMe
       expect(result.data.createUser.clientMutationId).toBe('123');
     });
   });

src/__tests__/nodeFieldConfig-test.js

@@ -59,8 +59,7 @@ describe('nodeFieldConfig', () => {
     const args = { id: toGlobalId('User', 1) };
     const context = {};
     const info = ({}: any);
-    const res = await config.resolve(source, args, context, info);
-    // $FlowFixMe
+    const res: any = await config.resolve(source, args, context, info);
     expect(res.name).toBe('Pavel');
   });
 });

src/__tests__/wrapMutationResolver.js

@@ -39,8 +39,7 @@ describe('wrapMutationResolver', () => {
         expect.arrayContaining(['input'])
       );
 
-      const type = getNamedType(fieldConfigManyArgsWithoutInput.args.input.type);
-      // $FlowFixMe
+      const type: any = getNamedType(fieldConfigManyArgsWithoutInput.args.input.type);
       const itc = new InputTypeComposer(type);
       expect(itc.hasField('sort')).toBe(true);
       expect(itc.hasField('limit')).toBe(true);
@@ -52,8 +51,7 @@ describe('wrapMutationResolver', () => {
         expect.arrayContaining(['input', 'sort', 'limit'])
       );
 
-      const type = getNamedType(fieldConfigManyArgsWithInput.args.input.type);
-      // $FlowFixMe
+      const type: any = getNamedType(fieldConfigManyArgsWithInput.args.input.type);
       const itc = new InputTypeComposer(type);
       expect(itc.hasField('sort')).toBe(false);
       expect(itc.hasField('limit')).toBe(false);

src/nodeFieldConfig.js

@@ -17,7 +17,7 @@ export function getNodeFieldConfig(typeMapForRelayNode: TypeMapForRelayNode) {
     type: NodeInterface,
     args: {
       id: {
-        type: new GraphQLNonNull(GraphQLID),
+        type: (new GraphQLNonNull(GraphQLID): $FlowFixMe),
         description: 'The globally unique ID among all types',
       },
     },
@@ -36,7 +36,6 @@ export function getNodeFieldConfig(typeMapForRelayNode: TypeMapForRelayNode) {
         return null;
       }
       const { tc, resolver: findById } = typeMapForRelayNode[type];
-
       if (findById && findById.resolve && tc) {
         const graphqlType = tc.getType();
 

src/wrapMutationResolver.js

@@ -26,7 +26,7 @@ export default function wrapMutationResolver<TSource, TContext>(
 ): Resolver<TSource, TContext> {
   const { resolverName, rootTypeName } = opts;
 
-  function prepareArgs(newResolver) {
+  function prepareArgs(newResolver: Resolver<TSource, TContext>) {
     let ITC: InputTypeComposer;
     if (newResolver.args.input && newResolver.args.input.type) {
       const inputNamedType = getNamedType(newResolver.args.input.type);
@@ -36,10 +36,9 @@ export default function wrapMutationResolver<TSource, TContext>(
     } else {
       // create input arg, and put into all current args
 
-      // $FlowFixMe
       ITC = InputTypeComposer.create({
         name: `Relay${upperFirst(resolverName)}${rootTypeName}Input`,
-        fields: newResolver.args,
+        fields: (newResolver.args: any),
       });
       newResolver.setArgs({
         input: {