feat: improve return types for findByIds & findMany now they returns empty array instead of null

BREAKING CHANGE: some internal `filter` type names for args were changed. It may break some clients if you use that type names in your graphql queries:
- `count` resolver change name for filter type `Filter*Input` -> `FilterCount*Input`

Author: nodkz

src/__tests__/github_issues/136-test.ts

@@ -37,7 +37,7 @@ describe('issue #136 - Mongoose virtuals', () => {
     const recordsTC = CommentTC.getResolver('createMany').getArgITC('records');
     const clonedRecordTC = recordsTC.clone('createManyFilteredInput');
     clonedRecordTC.removeField('links').addFields({ hi: 'String' });
-    updateManyFiltered.extendArg('records', { type: clonedRecordTC.getTypePlural() });
+    updateManyFiltered.extendArg('records', { type: clonedRecordTC.List });
 
     return updateManyFiltered
       .wrapResolve((next) => async (rp) => {

src/discriminators/prepareBaseResolvers.ts

@@ -35,7 +35,7 @@ export function prepareBaseResolvers(baseTC: DiscriminatorTypeComposer<any, any>
       switch (resolverName) {
         case EMCResolvers.findMany:
         case EMCResolvers.findByIds:
-          resolver.setType(baseTC.getDInterface().getTypePlural());
+          resolver.setType(baseTC.getDInterface().List);
           // @ts-expect-error
           resolver.projection[baseTC.getDKey()] = 1;
           break;
@@ -62,7 +62,7 @@ export function prepareBaseResolvers(baseTC: DiscriminatorTypeComposer<any, any>
 
         case EMCResolvers.createMany:
           resolver.getOTC().extendField('records', {
-            type: baseTC.getDInterface().getTypePlural().getTypeNonNull(),
+            type: baseTC.getDInterface().List.NonNull,
             projection: {
               [baseTC.getDKey()]: 1,
             },
@@ -71,7 +71,7 @@ export function prepareBaseResolvers(baseTC: DiscriminatorTypeComposer<any, any>
 
         case EMCResolvers.pagination:
           resolver.getOTC().extendField('items', {
-            type: baseTC.getDInterface().getTypePlural(),
+            type: baseTC.getDInterface().List,
             projection: {
               [baseTC.getDKey()]: 1,
             },
@@ -85,15 +85,13 @@ export function prepareBaseResolvers(baseTC: DiscriminatorTypeComposer<any, any>
             .clone(`${baseTC.getTypeName()}Edge`);
 
           edgesTC.extendField('node', {
-            type: baseTC.getDInterface().getTypeNonNull(),
+            type: baseTC.getDInterface().NonNull,
             projection: {
               [baseTC.getDKey()]: 1,
             },
           });
 
-          resolver
-            .getOTC()
-            .setField('edges', edgesTC.getTypeNonNull().getTypePlural().getTypeNonNull());
+          resolver.getOTC().setField('edges', edgesTC.NonNull.List.NonNull);
           break;
 
         default:
@@ -106,7 +104,7 @@ export function prepareBaseResolvers(baseTC: DiscriminatorTypeComposer<any, any>
       if (resolverName === EMCResolvers.createOne || resolverName === EMCResolvers.createMany) {
         const fieldName = resolverName === EMCResolvers.createMany ? 'records' : 'record';
         resolver.getArgITC(fieldName).extendField(baseTC.getDKey(), {
-          type: baseTC.getDKeyETC().getTypeNonNull(),
+          type: baseTC.getDKeyETC().NonNull,
         });
       }
     }

src/resolvers/__tests__/count-test.ts

@@ -61,7 +61,7 @@ describe('count() ->', () => {
       const resolver = count(UserModel, UserTC);
       expect(resolver.getArgITC('filter').getFieldITC('contacts').toSDL({ omitDescriptions: true }))
         .toMatchInlineSnapshot(`
-        "input FilterUserContactsInput {
+        "input FilterCountUserContactsInput {
           phones: [String]
           email: String
           skype: String

src/resolvers/count.ts

@@ -25,7 +25,7 @@ export default function count<TSource = Document, TContext = any>(
     kind: 'query',
     args: {
       ...filterHelperArgs(tc, model, {
-        prefix: 'Filter', // TODO: rename to FilterCount in 9.0.0
+        prefix: 'FilterCount',
         suffix: 'Input',
         ...opts?.filter,
       }),

src/resolvers/createMany.ts

@@ -37,6 +37,7 @@ export default function createMany<TSource = Document, TContext = any>(
       recordIds: {
         type: '[MongoID!]!',
         description: 'Created document IDs',
+        resolve: (s: any) => s.recordIds || [],
       },
       records: {
         type: tc.NonNull.List,

src/resolvers/findByIds.ts

@@ -29,7 +29,7 @@ export default function findByIds<TSource = Document, TContext = any>(
   const aliases = prepareAliases(model);
 
   return tc.schemaComposer.createResolver({
-    type: tc.getTypeNonNull().getTypePlural(),
+    type: tc.NonNull.List.NonNull,
     name: 'findByIds',
     kind: 'query',
     args: {
@@ -58,7 +58,7 @@ export default function findByIds<TSource = Document, TContext = any>(
       projectionHelper(resolveParams, aliases);
       limitHelper(resolveParams);
       sortHelper(resolveParams);
-      return beforeQueryHelper(resolveParams);
+      return beforeQueryHelper(resolveParams) || [];
     }) as any,
   }) as any;
 }

src/resolvers/findMany.ts

@@ -31,7 +31,7 @@ export default function findMany<TSource = Document, TContext = any>(
   const aliases = prepareAliases(model);
 
   return tc.schemaComposer.createResolver({
-    type: tc.getTypeNonNull().getTypePlural(),
+    type: tc.NonNull.List.NonNull,
     name: 'findMany',
     kind: 'query',
     args: {
@@ -57,7 +57,7 @@ export default function findMany<TSource = Document, TContext = any>(
       limitHelper(resolveParams);
       sortHelper(resolveParams);
       projectionHelper(resolveParams, aliases);
-      return beforeQueryHelper(resolveParams);
+      return beforeQueryHelper(resolveParams) || [];
     }) as any,
   });
 }

src/resolvers/helpers/filter.ts

@@ -91,7 +91,7 @@ export const filterHelperArgs = (
 
   return {
     filter: {
-      type: opts.isRequired ? itc.getTypeNonNull() : itc,
+      type: opts.isRequired ? itc.NonNull : itc,
       description: opts.onlyIndexed ? 'Filter only by indexed fields' : 'Filter by fields',
     },
   };

src/resolvers/helpers/filterOperators.ts

@@ -51,8 +51,8 @@ export function addFilterOperators(
   }
 
   itc.addFields({
-    OR: [itc.getTypeNonNull()],
-    AND: [itc.getTypeNonNull()],
+    OR: itc.NonNull.List,
+    AND: itc.NonNull.List,
   });
 }
 

src/resolvers/helpers/record.ts

@@ -59,7 +59,7 @@ export const recordHelperArgs = (
 
   return {
     record: {
-      type: opts.isRequired ? recordITC.getTypeNonNull() : recordITC,
+      type: opts.isRequired ? recordITC.NonNull : recordITC,
     },
   };
 };