Skip to content

Commit 5486a9b

Browse files
committed
feat: Remove graphql-js peer-dependency. Using it via graphql-compose re-export.
1 parent 7450c5e commit 5486a9b

36 files changed

+133
-130
lines changed

src/__tests__/fieldConverter-test.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,7 @@
11
/* @flow */
22
/* eslint-disable no-unused-expressions, no-template-curly-in-string */
33

4-
import {
5-
GraphQLString,
6-
GraphQLFloat,
7-
GraphQLBoolean,
8-
GraphQLList,
9-
GraphQLEnumType,
10-
GraphQLSchema,
11-
GraphQLObjectType,
12-
graphql,
13-
} from 'graphql';
14-
import { GraphQLDate, GraphQLBuffer, GraphQLGeneric, GraphQLJSON } from 'graphql-compose';
4+
import { GraphQLDate, GraphQLBuffer, GraphQLGeneric, GraphQLJSON, graphql } from 'graphql-compose';
155
import { UserModel } from '../__mocks__/userModel';
166
import {
177
deriveComplexType,
@@ -29,6 +19,16 @@ import {
2919
import { composeWithMongoose } from '../composeWithMongoose';
3020
import GraphQLMongoID from '../types/mongoid';
3121

22+
const {
23+
GraphQLString,
24+
GraphQLFloat,
25+
GraphQLBoolean,
26+
GraphQLList,
27+
GraphQLEnumType,
28+
GraphQLSchema,
29+
GraphQLObjectType,
30+
} = graphql;
31+
3232
describe('fieldConverter', () => {
3333
const fields = getFieldsFromModel(UserModel);
3434
const fieldNames = Object.keys(fields);
@@ -197,7 +197,7 @@ describe('fieldConverter', () => {
197197
name: 'Test empty subDoc',
198198
});
199199
await user.save();
200-
const result = await graphql(
200+
const result = await graphql.graphql(
201201
schema,
202202
`{
203203
user(_id: "${user._id}") {
@@ -239,7 +239,7 @@ describe('fieldConverter', () => {
239239
subDoc: { field2: { field21: 'ok' } },
240240
});
241241
await user2.save();
242-
const result2 = await graphql(
242+
const result2 = await graphql.graphql(
243243
schema,
244244
`{
245245
user(_id: "${user2._id}") {
@@ -322,7 +322,7 @@ describe('fieldConverter', () => {
322322
someDynamic
323323
}
324324
}`;
325-
const result = await graphql(schema, query);
325+
const result = await graphql.graphql(schema, query);
326326
expect(result.data.user.name).toBe(user.name);
327327
expect(result.data.user.someDynamic).toEqual(user.someDynamic);
328328
});

src/definition.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,14 +86,14 @@ import type {
8686
GraphQLObjectType as _GraphQLObjectType,
8787
GraphQLOutputType as _GraphQLOutputType,
8888
ResolveParams as _ResolveParams,
89-
GraphQLFieldConfigArgumentMap as _GraphQLFieldConfigArgumentMap,
89+
ComposeFieldConfigArgumentMap as _ComposeFieldConfigArgumentMap,
9090
ResolverMWResolveFn as _ResolverMWResolveFn,
9191
GraphQLResolveInfo as _GraphQLResolveInfo,
9292
} from 'graphql-compose/lib/definition.js';
9393

9494
export type GraphQLObjectType = _GraphQLObjectType;
9595
export type GraphQLOutputType = _GraphQLOutputType;
96-
export type GraphQLFieldConfigArgumentMap = _GraphQLFieldConfigArgumentMap;
96+
export type ComposeFieldConfigArgumentMap = _ComposeFieldConfigArgumentMap;
9797
export type ResolveParams<TSource, TContext> = _ResolveParams<TSource, TContext>;
9898
export type GraphQLResolveInfo = _GraphQLResolveInfo;
9999
export type ResolverMWResolveFn<TSource, TContext> = _ResolverMWResolveFn<TSource, TContext>;

src/fieldsConverter.js

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,9 @@ import {
99
GraphQLBuffer,
1010
GraphQLGeneric,
1111
GraphQLJSON,
12+
graphql,
1213
} from 'graphql-compose';
1314

14-
import {
15-
GraphQLString,
16-
GraphQLFloat,
17-
GraphQLBoolean,
18-
GraphQLList,
19-
GraphQLEnumType,
20-
GraphQLObjectType,
21-
} from 'graphql';
2215
import GraphQLMongoID from './types/mongoid';
2316
import typeStorage from './typeStorage';
2417

@@ -32,6 +25,15 @@ import type {
3225
GraphQLOutputType,
3326
} from './definition';
3427

28+
const {
29+
GraphQLString,
30+
GraphQLFloat,
31+
GraphQLBoolean,
32+
GraphQLList,
33+
GraphQLEnumType,
34+
GraphQLObjectType,
35+
} = graphql;
36+
3537
export const ComplexTypes = {
3638
ARRAY: 'ARRAY',
3739
EMBEDDED: 'EMBEDDED',

src/resolvers/__tests__/count-test.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
/* @flow */
22

3-
import { GraphQLInt } from 'graphql';
4-
import { Resolver } from 'graphql-compose';
3+
import { Resolver, graphql } from 'graphql-compose';
54
import { UserModel } from '../../__mocks__/userModel';
65
import count from '../count';
76
import { composeWithMongoose } from '../../composeWithMongoose';
87
import typeStorage from '../../typeStorage';
98

9+
const { GraphQLInt } = graphql;
10+
1011
describe('count() ->', () => {
1112
let UserTypeComposer;
1213

src/resolvers/__tests__/createOne-test.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
/* @flow */
22
/* eslint-disable no-param-reassign */
33

4-
import { GraphQLNonNull, GraphQLObjectType } from 'graphql';
5-
import { Resolver, TypeComposer } from 'graphql-compose';
4+
import { Resolver, TypeComposer, graphql } from 'graphql-compose';
65
import { UserModel } from '../../__mocks__/userModel';
76
import createOne from '../createOne';
87
import { composeWithMongoose } from '../../composeWithMongoose';
98
import GraphQLMongoID from '../../types/mongoid';
109
import typeStorage from '../../typeStorage';
1110

11+
const { GraphQLNonNull, GraphQLObjectType } = graphql;
12+
1213
describe('createOne() ->', () => {
1314
let UserTypeComposer;
1415

src/resolvers/__tests__/findById-test.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
/* @flow */
22

3-
import { GraphQLNonNull } from 'graphql';
4-
import { Resolver } from 'graphql-compose';
3+
import { Resolver, graphql } from 'graphql-compose';
54
import { UserModel } from '../../__mocks__/userModel';
65
import { PostModel } from '../../__mocks__/postModel';
76
import findById from '../findById';
87
import GraphQLMongoID from '../../types/mongoid';
98
import { composeWithMongoose } from '../../composeWithMongoose';
109
import typeStorage from '../../typeStorage';
1110

11+
const { GraphQLNonNull } = graphql;
12+
1213
describe('findById() ->', () => {
1314
let UserTypeComposer;
1415
let PostTypeComposer;

src/resolvers/__tests__/findByIds-test.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
/* @flow */
22

3-
import { GraphQLNonNull, GraphQLList } from 'graphql';
4-
import { Resolver } from 'graphql-compose';
3+
import { Resolver, graphql } from 'graphql-compose';
54
import { UserModel } from '../../__mocks__/userModel';
65
import { PostModel } from '../../__mocks__/postModel';
76
import findByIds from '../findByIds';
87
import GraphQLMongoID from '../../types/mongoid';
98
import { composeWithMongoose } from '../../composeWithMongoose';
109
import typeStorage from '../../typeStorage';
1110

11+
const { GraphQLNonNull, GraphQLList } = graphql;
12+
1213
describe('findByIds() ->', () => {
1314
let UserTypeComposer;
1415
let PostTypeComposer;

src/resolvers/__tests__/findOne-test.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
/* @flow */
22

3-
import { GraphQLNonNull } from 'graphql';
4-
import { Resolver } from 'graphql-compose';
3+
import { Resolver, graphql } from 'graphql-compose';
54
import { UserModel } from '../../__mocks__/userModel';
65
import findOne from '../findOne';
76
import { composeWithMongoose } from '../../composeWithMongoose';
87
import typeStorage from '../../typeStorage';
98

9+
const { GraphQLNonNull } = graphql;
10+
1011
describe('findOne() ->', () => {
1112
let UserTypeComposer;
1213

src/resolvers/__tests__/removeById-test.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
/* @flow */
22
/* eslint-disable no-param-reassign */
33

4-
import { GraphQLNonNull, GraphQLObjectType } from 'graphql';
5-
import { Resolver, TypeComposer } from 'graphql-compose';
4+
import { Resolver, TypeComposer, graphql } from 'graphql-compose';
65
import { UserModel } from '../../__mocks__/userModel';
76
import removeById from '../removeById';
87
import GraphQLMongoID from '../../types/mongoid';
98
import { composeWithMongoose } from '../../composeWithMongoose';
109
import typeStorage from '../../typeStorage';
1110

11+
const { GraphQLNonNull, GraphQLObjectType } = graphql;
12+
1213
describe('removeById() ->', () => {
1314
let UserTypeComposer;
1415

@@ -66,7 +67,7 @@ describe('removeById() ->', () => {
6667
_id: user.id,
6768
},
6869
});
69-
expect(result).toHaveProperty('recordId', user.id);
70+
expect(result.recordId).toBe(user.id);
7071
});
7172

7273
it('should return error if document does not exist', () => {

src/resolvers/__tests__/removeMany-test.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
/* @flow */
22

3-
import { GraphQLInt, GraphQLNonNull, GraphQLObjectType } from 'graphql';
43
import { Query } from 'mongoose';
5-
import { Resolver, TypeComposer } from 'graphql-compose/';
4+
import { Resolver, TypeComposer, graphql } from 'graphql-compose';
65
import { UserModel } from '../../__mocks__/userModel';
76
import removeMany from '../removeMany';
87
import { composeWithMongoose } from '../../composeWithMongoose';
98
import typeStorage from '../../typeStorage';
109

10+
const { GraphQLInt, GraphQLNonNull, GraphQLObjectType } = graphql;
11+
1112
describe('removeMany() ->', () => {
1213
let UserTypeComposer;
1314

@@ -99,7 +100,7 @@ describe('removeMany() ->', () => {
99100
filter: { gender: 'female' },
100101
},
101102
});
102-
expect(result).toHaveProperty('numAffected', 2);
103+
expect(result.numAffected).toBe(2);
103104
});
104105

105106
it('should call `beforeQuery` method with non-executed `query` as arg', async () => {
@@ -115,7 +116,7 @@ describe('removeMany() ->', () => {
115116
},
116117
});
117118
expect(beforeQueryCalled).toBe(true);
118-
expect(result).toHaveProperty('numAffected', 2);
119+
expect(result.numAffected).toBe(2);
119120
});
120121
});
121122

0 commit comments

Comments
 (0)