store: Asyncify details

Author: lutter

store/postgres/src/deployment.rs

@@ -1227,7 +1227,7 @@ pub async fn create_deployment(
         d::debug_fork.eq(debug_fork.as_ref().map(|s| s.as_str())),
     );
 
-    let graph_node_version_id = GraphNodeVersion::create_or_get(conn)?;
+    let graph_node_version_id = GraphNodeVersion::create_or_get(conn).await?;
 
     let manifest_values = (
         m::id.eq(site.id),

store/postgres/src/deployment_store.rs

@@ -267,6 +267,7 @@ impl DeploymentStore {
         let layout = self.layout(&mut conn, site.clone()).await?;
         Ok(
             detail::deployment_entity(&mut conn, &site, &layout.input_schema)
+                .await
                 .with_context(|| format!("Deployment details not found for {}", site.deployment))?,
         )
     }
@@ -551,7 +552,7 @@ impl DeploymentStore {
         ids: Vec<String>,
     ) -> Result<Vec<DeploymentDetail>, StoreError> {
         let conn = &mut *self.get_conn().await?;
-        detail::deployment_details(conn, ids)
+        detail::deployment_details(conn, ids).await
     }
 
     pub async fn deployment_details_for_id(
@@ -560,15 +561,15 @@ impl DeploymentStore {
     ) -> Result<DeploymentDetail, StoreError> {
         let id = DeploymentId::from(locator.clone());
         let conn = &mut *self.get_conn().await?;
-        detail::deployment_details_for_id(conn, &id)
+        detail::deployment_details_for_id(conn, &id).await
     }
 
     pub(crate) async fn deployment_statuses(
         &self,
         sites: &[Arc<Site>],
     ) -> Result<Vec<status::Info>, StoreError> {
         let conn = &mut *self.get_conn().await?;
-        detail::deployment_statuses(conn, sites)
+        detail::deployment_statuses(conn, sites).await
     }
 
     pub(crate) async fn deployment_exists_and_synced(
@@ -1005,7 +1006,7 @@ impl DeploymentStore {
                 if latest_block_ptr.number < block.number {
                     // If a subgraph has failed deterministically then any blocks past head
                     // should return the same POI
-                    let fatal_error = ErrorDetail::fatal(conn, &site.deployment)?;
+                    let fatal_error = ErrorDetail::fatal(conn, &site.deployment).await?;
                     block_ptr = match fatal_error {
                         Some(se) => TryInto::<SubgraphError>::try_into(se)?
                             .block_ptr
@@ -1732,7 +1733,7 @@ impl DeploymentStore {
         conn.transaction_async(|conn| {
             async {
             // We'll only unfail subgraphs that had fatal errors
-            let subgraph_error = match ErrorDetail::fatal(conn, deployment_id)? {
+            let subgraph_error = match ErrorDetail::fatal(conn, deployment_id).await? {
                 Some(fatal_error) => fatal_error,
                 // If the subgraph is not failed then there is nothing to do.
                 None => return Ok(UnfailOutcome::Noop),
@@ -1828,7 +1829,7 @@ impl DeploymentStore {
 
         conn.transaction_async(|conn| async {
             // We'll only unfail subgraphs that had fatal errors
-            let subgraph_error = match ErrorDetail::fatal(conn, deployment_id)? {
+            let subgraph_error = match ErrorDetail::fatal(conn, deployment_id).await? {
                 Some(fatal_error) => fatal_error,
                 // If the subgraph is not failed then there is nothing to do.
                 None => return Ok(UnfailOutcome::Noop),

store/postgres/src/detail.rs

@@ -153,7 +153,7 @@ pub(crate) struct ErrorDetail {
 impl ErrorDetail {
     /// Fetches the fatal error, if present, associated with the given
     /// [`DeploymentHash`].
-    pub fn fatal(
+    pub async fn fatal(
         conn: &mut PgConnection,
         deployment_id: &DeploymentHash,
     ) -> Result<Option<Self>, StoreError> {
@@ -305,7 +305,7 @@ pub(crate) fn info_from_details(
 }
 
 /// Return the details for `deployments`
-pub(crate) fn deployment_details(
+pub(crate) async fn deployment_details(
     conn: &mut PgConnection,
     deployments: Vec<String>,
 ) -> Result<Vec<DeploymentDetail>, StoreError> {
@@ -334,7 +334,7 @@ pub(crate) fn deployment_details(
 }
 
 /// Return the details for `deployment`
-pub(crate) fn deployment_details_for_id(
+pub(crate) async fn deployment_details_for_id(
     conn: &mut PgConnection,
     deployment: &DeploymentId,
 ) -> Result<DeploymentDetail, StoreError> {
@@ -352,7 +352,7 @@ pub(crate) fn deployment_details_for_id(
         .map(DeploymentDetail::from)
 }
 
-pub(crate) fn deployment_statuses(
+pub(crate) async fn deployment_statuses(
     conn: &mut PgConnection,
     sites: &[Arc<Site>],
 ) -> Result<Vec<status::Info>, StoreError> {
@@ -538,7 +538,7 @@ impl StoredDeploymentEntity {
     }
 }
 
-pub fn deployment_entity(
+pub async fn deployment_entity(
     conn: &mut PgConnection,
     site: &Site,
     schema: &InputSchema,
@@ -575,7 +575,7 @@ pub struct GraphNodeVersion {
 }
 
 impl GraphNodeVersion {
-    pub(crate) fn create_or_get(conn: &mut PgConnection) -> anyhow::Result<i32> {
+    pub(crate) async fn create_or_get(conn: &mut PgConnection) -> anyhow::Result<i32> {
         let git_commit_hash = version_commit_hash!();
         let git_repository_dirty = !&TESTAMENT.modifications.is_empty();
         let crate_version = CARGO_PKG_VERSION;