store: Remove support for synchronous connections

Author: lutter

store/postgres/src/lib.rs

@@ -62,8 +62,7 @@ pub use self::detail::DeploymentDetail;
 pub use self::jobs::register as register_jobs;
 pub use self::notification_listener::NotificationSender;
 pub use self::pool::{
-    AsyncConnection, AsyncPgConnection, ConnectionPool, ForeignServer, PgConnection,
-    PoolCoordinator, PoolRole, ScopedFutureExt,
+    AsyncPgConnection, ConnectionPool, ForeignServer, PoolCoordinator, PoolRole, ScopedFutureExt,
 };
 pub use self::primary::{db_version, UnusedDeployment};
 pub use self::store::Store;

store/postgres/src/pool/async_txn.rs

@@ -26,23 +26,19 @@ use crate::catalog;
 use crate::primary::{self, Mirror, Namespace};
 use crate::{Shard, PRIMARY_SHARD};
 
-mod async_txn;
 mod coordinator;
 mod foreign_server;
 mod state_tracker;
 
 pub use diesel_async::scoped_futures::ScopedFutureExt;
 
-pub use async_txn::AsyncConnection;
 pub use coordinator::PoolCoordinator;
 pub use foreign_server::ForeignServer;
 use state_tracker::{ErrorHandler, EventHandler, StateTracker};
 
 type AsyncPool = mobc::Pool<diesel_async::AsyncPgConnection>;
 /// A database connection for asynchronous diesel operations
 pub type AsyncPgConnection = mobc::PooledConnection<diesel_async::AsyncPgConnection>;
-/// A database connection for 'classic' synchronous diesel operations
-pub type PgConnection = AsyncConnectionWrapper<AsyncPgConnection>;
 
 /// The namespace under which the `PRIMARY_TABLES` are mapped into each
 /// shard
@@ -321,12 +317,6 @@ impl ConnectionPool {
         self.get_ready()?.get().await
     }
 
-    /// An async version of `get`. For now, this calls `get` synchronously.
-    /// Once `get` is not used anymore, we can make it truly async.
-    pub async fn get_sync(&self) -> Result<PgConnection, StoreError> {
-        self.get().await.map(AsyncConnectionWrapper::from)
-    }
-
     /// Get a connection from the pool for foreign data wrapper access;
     /// since that pool can be very contended, periodically log that we are
     /// still waiting for a connection