Main upgrades in preparation for contract PRs (#1184)

- Upgrade to pnpm, improving package management and converging with Horizon.
- Restructure packages to remove dependency cycles. Instead of the sdk depending on contracts and contracts on sdk, contracts has child packages contracts-test and contracts-task that depend on sdk but that sdk does not depend on. These child packages depend on sdk, while contracts does not. A common package has also been created for shared dependencies of contract packages. There are now no dependency cycles, no SKIP_LOAD compiles, and dynamic loading has been converted to static imports.
- Numerous lint issues have been fixed. ESLint upgraded to v9 and natspec-smells linting added.
- GH workflows have been simplified. One for linting, one for build, test, and coverage test. Workflows use pnpm to find build, test, and test:coverage targets rather than needing separate configuration or per package workflows.

Author: RembrandtK

.changeset/smooth-balloons-stare.md

@@ -61,9 +61,8 @@ RUN curl -L https://foundry.paradigm.xyz | bash && \
     chmod 755 /usr/local/bin/forge && \
     chmod 755 /usr/local/bin/chisel
 
-# Set up yarn and pnpm
+# Set up pnpm
 RUN corepack enable && \
-    corepack prepare yarn@4.0.2 --activate && \
     corepack prepare pnpm@9.0.6 --activate
 
 # Ensure all users have access to the tools

.devcontainer/Dockerfile

@@ -33,7 +33,7 @@ The container uses a conservative caching approach to prevent cache corruption i
    - Python packages: `/home/vscode/.cache/pip`
 
 3. **Intentionally Not Cached**: These tools use their default cache locations to avoid contamination
-   - NPM, Yarn (different dependency versions per branch)
+   - NPM (different dependency versions per branch)
    - Foundry, Solidity (different compilation artifacts per branch)
    - Hardhat (different build artifacts per branch)
 
@@ -49,7 +49,7 @@ To start the dev container:
 
 When the container starts, the `project-setup.sh` script will automatically run and:
 
-- Install project dependencies using yarn
+- Install project dependencies using pnpm
 - Configure Git to use SSH signing with your forwarded SSH key
 - Source shell customizations if available in PATH
 
@@ -79,8 +79,8 @@ These environment variables are needed for Git commit signing to work properly.
 If you encounter build or compilation issues that seem related to cached artifacts:
 
 1. **Rebuild the container**: This will start with fresh local caches
-2. **Clean project caches**: Run `yarn clean` to clear project-specific build artifacts
-3. **Clear node modules**: Delete `node_modules` and run `yarn install` again
+2. **Clean project caches**: Run `pnpm clean` to clear project-specific build artifacts
+3. **Clear node modules**: Delete `node_modules` and run `pnpm install` again
 
 ### Git SSH Signing Issues
 

.devcontainer/README.md

@@ -24,7 +24,11 @@ services:
       - GH_CONFIG_DIR=/home/vscode/.cache/github
       - PIP_CACHE_DIR=/home/vscode/.cache/pip
 
-      # Note: NPM, Yarn, Foundry, and Solidity caches are intentionally not set
+      # pnpm cache is safe to share due to content-addressable storage
+      - PNPM_HOME=/home/vscode/.local/share/pnpm
+      - PNPM_CACHE_DIR=/home/vscode/.cache/pnpm
+
+      # Note: NPM, Foundry, and Solidity caches are intentionally not set
       # to avoid cross-branch contamination. Tools will use their default locations.
     volumes:
       # Git repo root

.devcontainer/docker-compose.yml

@@ -24,11 +24,11 @@ echo "User directories set up with proper permissions"
 # Install project dependencies
 echo "Installing project dependencies..."
 if [ -f "$REPO_ROOT/package.json" ]; then
-  echo "Running yarn to install dependencies..."
+  echo "Running pnpm to install dependencies..."
   cd "$REPO_ROOT"
-  # Note: With set -e, if yarn fails, the script will exit
+  # Note: With set -e, if pnpm fails, the script will exit
   # This is desirable as we want to ensure dependencies are properly installed
-  yarn
+  pnpm install
 else
   echo "No package.json found in the root directory, skipping dependency installation"
 fi

.devcontainer/project-setup.sh

@@ -9,14 +9,19 @@ runs:
       run: |
         sudo apt-get update
         sudo apt-get install -y libudev-dev libusb-1.0-0-dev
-    - name: Enable corepack for modern yarn
+    - name: Install Foundry
+      uses: foundry-rs/foundry-toolchain@v1
+    - name: Enable Corepack
       shell: bash
       run: corepack enable
     - name: Install Node.js
       uses: actions/setup-node@v4
       with:
         node-version: 20
-        cache: 'yarn'
+        cache: 'pnpm'
+    - name: Set up pnpm via Corepack
+      shell: bash
+      run: corepack prepare pnpm@9.0.6 --activate
     - name: Install dependencies
       shell: bash
-      run: yarn --immutable
+      run: pnpm install --frozen-lockfile

.github/actions/setup/action.yml

@@ -0,0 +1,50 @@
+name: Build and Test
+
+env:
+  CI: true
+  STUDIO_API_KEY: ${{ secrets.STUDIO_API_KEY }}
+
+on:
+  pull_request:
+    branches: '*'
+  workflow_dispatch:
+
+jobs:
+  test:
+    name: Build and Test
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          submodules: recursive
+
+      - name: Set up environment
+        uses: ./.github/actions/setup
+
+      - name: Build all packages
+        run: pnpm -r --sequential run build
+
+      - name: Test all packages
+        run: pnpm -r --sequential run test
+
+      - name: Test with coverage
+        run: pnpm -r --sequential run test:coverage
+
+      - name: Find coverage files
+        id: coverage_files
+        run: |
+          # Find all coverage-final.json files
+          COVERAGE_FILES=$(find ./packages -name "coverage-final.json" -path "*/reports/coverage/*" | tr '\n' ',' | sed 's/,$//')
+          echo "files=$COVERAGE_FILES" >> $GITHUB_OUTPUT
+          echo "Found coverage files: $COVERAGE_FILES"
+
+      - name: Upload coverage reports
+        if: steps.coverage_files.outputs.files != ''
+        uses: codecov/codecov-action@v3
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          files: ${{ steps.coverage_files.outputs.files }}
+          flags: unittests
+          name: graphprotocol-contracts
+          fail_ci_if_error: true