Skip to content

Commit 6690d6b

Browse files
committed
fix(container): removing unneeded shared network dependency, minor doc updates
1 parent ea650f2 commit 6690d6b

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

.devcontainer/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,14 +61,14 @@ When the container starts, the `project-setup.sh` script will automatically run
6161
- Set up symlinks for package cache directories
6262
- Install project dependencies using yarn
6363
- Configure Git to use SSH signing with your forwarded SSH key
64-
- Source shell customizations if available in PATH (currently depends on base image configuration)
64+
- Source shell customizations if available in PATH
6565

6666
## Environment Variables
6767

6868
Environment variables are defined in two places:
6969

7070
1. **docker-compose.yml**: Contains most of the environment variables for tools and caching
71-
2. **Environment File**: Personal settings are stored in `/opt/configs/graphprotocol/contracts.env`
71+
2. **Environment File**: Personal settings are stored in `/opt/configs/graphprotocol/contracts.env` on the host
7272

7373
### Git Configuration
7474

.devcontainer/docker-compose.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ services:
3838
- PIP_CACHE_DIR=/cache/pip
3939
- PYTHONPYCACHEPREFIX=/cache/pycache
4040
- PYTHONDONTWRITEBYTECODE=1
41-
networks:
42-
- shared
4341
volumes:
4442
# Mount cache directory
4543
- /cache:/cache
@@ -56,7 +54,3 @@ services:
5654
- /cache/vscode-config:/home/vscode/.config
5755
- /cache/vscode-data:/home/vscode/.local/share
5856
- /cache/vscode-bin:/home/vscode/.local/bin
59-
60-
networks:
61-
shared:
62-
external: true

0 commit comments

Comments
 (0)