You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make ResultProcessorBase destructor virtual so that derived classes have their destructors called.
Summary:
We create instances of `ResultProcessor` and `DummyResultProcessor`, but when they are destroyed they are pointers to `ResultProcessorBase`.
The non-virtual default destructor means the derived class destructor was not being called, potentially leaking memory.
Ref T57532
Reviewers: #tensorflow, #framework_ip_review_-_any_oss_or_third-party_code_use_has_been_approved, vladimirm
Reviewed By: #tensorflow, #framework_ip_review_-_any_oss_or_third-party_code_use_has_been_approved, vladimirm
Subscribers: vladimirm
Maniphest Tasks: T57532
Differential Revision: https://phabricator.sourcevertex.net/D62514
0 commit comments