Skip to content

Commit 8debb69

Browse files
jakeh-gcgeorgepaw
authored andcommitted
Poplar can't lookahead in the application runtime because the user drives the data pipeline.
Summary: What's changed: - Limit the lookahead of the application runtime. - This is because the data input is driven more directly by the user's python code. Ref T50668 Test Plan: CI tests Reviewers: #tensorflow, #framework_ip_review_-_any_oss_or_third-party_code_use_has_been_approved, jorgec, georgep Reviewed By: #tensorflow, #framework_ip_review_-_any_oss_or_third-party_code_use_has_been_approved, jorgec, georgep Subscribers: georgep, jorgec Maniphest Tasks: T50668 Differential Revision: https://phabricator.sourcevertex.net/D57128
1 parent 5fc413c commit 8debb69

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

tensorflow/compiler/plugin/poplar/kernels/application_runtime/application_runtime.cc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -646,7 +646,10 @@ class EngineResource {
646646
PoplarExecutableProto& proto)
647647
: engine_name_(engine_name),
648648
device_(std::move(device)),
649-
engine_(std::move(executable)),
649+
// Setting streamCallbacks.maxLookahead because we can't control the
650+
// user data inputs in the application runtime. This means we can't
651+
// gaurantee to poplar it can lookahead arbitrarily.
652+
engine_(std::move(executable), {{"streamCallbacks.maxLookahead", "0"}}),
650653
communication_manager_(proto, timeout_us) {}
651654

652655
poplar::Engine& GetEngine() { return engine_; }

0 commit comments

Comments
 (0)