Skip to content

Commit 86803ca

Browse files
Gautham Ganapathycaandewiel
authored andcommitted
Fix for asan / sandbox build failures
Summary: Asan and poplar sandbox builds fail due to removal of TF directory setup for libpopir.so REF T68545 Reviewers: #tensorflow, #framework_ip_review_-_any_oss_or_third-party_code_use_has_been_approved, frederikm, gauthamg Reviewed By: #tensorflow, #framework_ip_review_-_any_oss_or_third-party_code_use_has_been_approved, frederikm Subscribers: christiana Maniphest Tasks: T68545 Differential Revision: https://phabricator.sourcevertex.net/D74326
1 parent 7130431 commit 86803ca

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

third_party/ipus/poplar_configure.bzl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ def _poplar_autoconf_impl(repository_ctx):
4040

4141
repository_ctx.symlink(poplar_base + "/lib", "poplar/lib/poplar")
4242
repository_ctx.symlink(poplar_base + "/lib", "poplar/lib/popit")
43+
repository_ctx.symlink(poplar_base + "/lib", "poplar/lib/popir")
4344
repository_ctx.symlink(poplar_base + "/lib", "poplar/lib/poprithms")
4445
repository_ctx.symlink(poplar_base + "/lib/python", "poplar/lib/python")
4546
repository_ctx.symlink(poplar_base + "/bin", "poplar/poplar/bin")
@@ -48,6 +49,7 @@ def _poplar_autoconf_impl(repository_ctx):
4849
if repository_ctx.path(poplar_base + "/lib64").exists:
4950
repository_ctx.symlink(poplar_base + "/lib64", "poplar/lib64/poplar")
5051
repository_ctx.symlink(poplar_base + "/lib64", "poplar/lib64/popit")
52+
repository_ctx.symlink(poplar_base + "/lib64", "poplar/lib64/popir")
5153
repository_ctx.symlink(poplar_base + "/lib64", "poplar/lib64/poprithms")
5254
repository_ctx.symlink(poplar_base + "/lib64/python", "poplar/lib64/python")
5355

@@ -98,6 +100,7 @@ def _poplar_autoconf_impl(repository_ctx):
98100
repository_ctx.symlink(poplar_base + "/poplar/bin", "poplar/poplar/bin")
99101
repository_ctx.symlink(poplar_base + "/poplibs/lib", "poplar/lib/poplibs")
100102
repository_ctx.symlink(poplar_base + "/popit/lib", "poplar/lib/popit")
103+
repository_ctx.symlink(poplar_base + "/popir/lib", "poplar/lib/popir")
101104
repository_ctx.symlink(poplar_base + "/poprithms/lib", "poplar/lib/poprithms")
102105
repository_ctx.symlink(poplar_base + "/poplar/lib", "poplar/lib/poplar")
103106
repository_ctx.symlink(poplar_base + "/tbb/lib", "poplar/lib/tbb")
@@ -144,6 +147,7 @@ def _poplar_autoconf_impl(repository_ctx):
144147
repository_ctx.symlink(poplar_base + "/poplibs/lib64", "poplar/poplar/lib64/poplibs")
145148
repository_ctx.symlink(poplar_base + "/tbb/lib64", "poplar/lib64/tbb")
146149
repository_ctx.symlink(poplar_base + "/popit/lib64", "poplar/poplar/lib64/popit")
150+
repository_ctx.symlink(poplar_base + "/popir/lib64", "poplar/poplar/lib64/popir")
147151
repository_ctx.symlink(poplar_base + "/poprithms/lib64", "poplar/poplar/lib64/poprithms")
148152

149153
if repository_ctx.path(poplar_base + "/popef/lib64").exists:

third_party/ipus/poplar_lib/BUILD_poplar.tpl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ cc_library(
3636
"lib*/poplar/libpoplar.so",
3737
"lib*/poplar/libpoplar_test.so",
3838
"lib*/**/libpopsolver.so",
39+
"lib*/popit/libpopir.so",
3940
"lib*/popit/libpopit.so",
4041
"lib*/poprithms/libpoprithms.so",
4142
] + if_custom_poplibs([

0 commit comments

Comments
 (0)