Add a check that the binary was compiled with the correct TF version

Summary:
FIX T41133

Verify that the tensorflow and build versions of the embedded runtime match that of the runtime used to compile the executable.

Reviewers: #tensorflow, simonl, #framework_ip_review_-_any_oss_or_third-party_code_use_has_been_approved, georgep

Reviewed By: #tensorflow, #framework_ip_review_-_any_oss_or_third-party_code_use_has_been_approved, georgep

Subscribers: georgep

Maniphest Tasks: T41133

Differential Revision: https://phabricator.sourcevertex.net/D48627

Author: Gautham Ganapathy

tensorflow/compiler/plugin/poplar/driver/poplar_compiler.cc

@@ -1758,6 +1758,9 @@ StatusOr<std::unique_ptr<PoplarExecutableCore>> CompileEngine(
                   target_arch,
                   gateway_mode,
                   supports_remote_buffers,
+                  TF_MAJOR_VERSION,
+                  TF_MINOR_VERSION,
+                  tf_git_version(),
                   replication_factor,
                   annotations.infeed_infos,
                   annotations.outfeed_infos,
@@ -1842,6 +1845,9 @@ StatusOr<std::unique_ptr<PoplarExecutableCore>> CompileEngine(
               target_arch,
               gateway_mode,
               supports_remote_buffers,
+              TF_MAJOR_VERSION,
+              TF_MINOR_VERSION,
+              tf_git_version(),
               replication_factor,
               std::move(resources.annotations.infeed_infos),
               std::move(resources.annotations.outfeed_infos),

tensorflow/compiler/plugin/poplar/driver/poplar_executable.cc

@@ -30,7 +30,7 @@ limitations under the License.
 #include "tensorflow/compiler/plugin/poplar/driver/tools/tracepoint.h"
 #include "tensorflow/compiler/plugin/poplar/driver/tools/util.h"
 #include "tensorflow/compiler/plugin/poplar/driver/xla_ipu_common.h"
-#include "tensorflow/core/platform/stacktrace.h"
+#include "tensorflow/core/public/version.h"
 
 namespace xla {
 namespace poplarplugin {
@@ -82,6 +82,10 @@ PoplarExecutableInfo FromProto(const PoplarExecutableProto& proto,
   info.gateway_mode = ertc.gateway_mode();
   info.supports_remote_buffers = ertc.supports_remote_buffers();
 
+  info.tf_major_version = proto.tf_major_version();
+  info.tf_minor_version = proto.tf_minor_version();
+  info.tf_git_version = proto.tf_git_version();
+
   info.replication_factor = proto.replication_factor();
 
   for (const auto& infeed : proto.infeeds()) {
@@ -181,6 +185,10 @@ PoplarExecutableProto ToProto(const PoplarExecutableInfo& info,
   ertc->set_gateway_mode(info.gateway_mode);
   ertc->set_supports_remote_buffers(info.supports_remote_buffers);
 
+  proto.set_tf_major_version(info.tf_major_version);
+  proto.set_tf_minor_version(info.tf_minor_version);
+  proto.set_tf_git_version(info.tf_git_version);
+
   proto.set_replication_factor(info.replication_factor);
 
   for (const auto& infeed : info.infeed_infos) {

tensorflow/compiler/plugin/poplar/driver/poplar_executable.h

@@ -45,7 +45,9 @@ struct PoplarExecutableInfo {
   std::string target_arch;
   bool gateway_mode;
   bool supports_remote_buffers;
-
+  uint32 tf_major_version;
+  uint32 tf_minor_version;
+  std::string tf_git_version;
   uint32 replication_factor;
   CanonicalInfeedInfos infeed_infos;
   CanonicalOutfeedInfos outfeed_infos;

tensorflow/compiler/plugin/poplar/driver/poplar_executable.proto

@@ -117,4 +117,8 @@ message PoplarExecutableProto {
   bool logging_cycle_count = 13;
 
   EmbeddedRuntimeConfig embedded_runtime_config = 14;
+
+  uint32 tf_major_version = 15;
+  uint32 tf_minor_version = 16;
+  string tf_git_version = 17;
 };

tensorflow/compiler/plugin/poplar/kernels/datastream/application_runtime.cc

@@ -388,6 +388,21 @@ class ApplicationRuntime : public OpKernel {
       poplar::Executable executable =
           PoplarExecutableBinaryFile::Read(filename_, &proto).ValueOrDie();
 
+      OP_REQUIRES(ctx,
+                  proto.tf_major_version() == TF_MAJOR_VERSION &&
+                      proto.tf_minor_version() == TF_MINOR_VERSION,
+                  errors::InvalidArgument(absl::StrFormat(
+                      "TF version mismatch. Runtime version is %u.%u, "
+                      "executable version is %u.%u",
+                      TF_MAJOR_VERSION, TF_MINOR_VERSION,
+                      proto.tf_major_version(), proto.tf_minor_version())));
+
+      OP_REQUIRES(ctx, proto.tf_git_version() == tf_git_version(),
+                  errors::InvalidArgument(absl::StrFormat(
+                      "TF build version mismatch. Runtime version is %s, "
+                      "executable version is %s",
+                      tf_git_version(), proto.tf_git_version())));
+
       auto& ertc = proto.embedded_runtime_config();
       const std::string target_type_string = ertc.target_type();
       poplar::TargetType target_type;