This repository was archived by the owner on Mar 10, 2025. It is now read-only.
Add DirtyCheck annotation #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DirtyCheck annotation has been added to the AbstractAclObjectIdentity class to improve change tracking. Additionally, a 'change owner' function with corresponding integration tests has been added to the AclUtilServiceSpec class to allow for changing the owner of an object. The tests ensure that the change in ownership is properly reflected in both Acl and persistent data.
Modified the changeOwner method in AclUtilService.groovy to handle various types of input recipients. The new recipient can be a username, role name, Sid, or Authentication.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue when aclUtilService.changeOwner() doesn't persist changes to database due to AclObjectIdentity doesn't see changed property as dirty so it is never saved.
The DirtyCheck annotation has been added to the AbstractAclObjectIdentity class to improve change tracking. Additionally, a 'change owner' function with corresponding integration tests has been added to the AclUtilServiceSpec class to allow for changing the owner of an object. The tests ensure that the change in ownership is properly reflected in both Acl and persistent data.