Merge pull request #214 from grafana/20220908_created-at-flag

simonswine · web-flow · commit b1583e43ae4e · 2022-09-09T08:26:22.000+01:00
Add createdBy metadata to point to fire and its version
diff --git a/pkg/firedb/deduplicating_slice.go b/pkg/firedb/deduplicating_slice.go
@@ -13,6 +13,7 @@ import (
 
 	"github.com/grafana/fire/pkg/firedb/block"
 	schemav1 "github.com/grafana/fire/pkg/firedb/schemas/v1"
+	"github.com/grafana/fire/pkg/util/build"
 )
 
 var int64SlicePool = &sync.Pool{
@@ -55,6 +56,7 @@ func (s *deduplicatingSlice[M, K, H, P]) Init(path string) error {
 	// TODO: Reuse parquet.Writer beyond life time of the head.
 	s.writer = parquet.NewWriter(file, s.persister.Schema(),
 		parquet.ColumnPageBuffers(parquet.NewFileBufferPool(os.TempDir(), "firedb-parquet-buffers*")),
+		parquet.CreatedBy("github.com/grafana/fire/"+build.Version),
 	)
 	s.lookup = make(map[K]int64)
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@ import (`
`13`	`13`
`14`	`14`	`"github.com/grafana/fire/pkg/firedb/block"`
`15`	`15`	`schemav1 "github.com/grafana/fire/pkg/firedb/schemas/v1"`
	`16`	`+ "github.com/grafana/fire/pkg/util/build"`
`16`	`17`	`)`
`17`	`18`
`18`	`19`	`var int64SlicePool = &sync.Pool{`
`@@ -55,6 +56,7 @@ func (s *deduplicatingSlice[M, K, H, P]) Init(path string) error {`
`55`	`56`	`// TODO: Reuse parquet.Writer beyond life time of the head.`
`56`	`57`	`s.writer = parquet.NewWriter(file, s.persister.Schema(),`
`57`	`58`	`parquet.ColumnPageBuffers(parquet.NewFileBufferPool(os.TempDir(), "firedb-parquet-buffers*")),`
	`59`	`+ parquet.CreatedBy("github.com/grafana/fire/"+build.Version),`
`58`	`60`	`)`
`59`	`61`	`s.lookup = make(map[K]int64)`
`60`	`62`	`return nil`