chore: Redis Enterprise modern library usage #1538
Open
+3,942
−7,549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalhour
requested changes
Nov 12, 2025
aalhour
left a comment
aalhour
left a comment
There was a problem hiding this comment.
First pass, no linting errors locally, a few typos and an issue with alerts, everything else is minor.
| redisEnterpriseNodes: | ||
| link.link.new('Redis Enterprise nodes', '/d/' + this.grafana.dashboards['redis-enterprise-node-overview.json'].uid), | ||
| redisEnterpriseDatabases: | ||
| link.link.new('Redis Enterprise databases', '/d/' + this.grafana.dashboards['redis-enterprise-database-overview.jsonn'].uid), |
| refresh, | ||
| period, | ||
| ), | ||
| 'redis-enterprise-database-overview.jsonn': |
| clusterTotalRequests: { | ||
| name: 'Cluster total requests', | ||
| nameShort: 'Total requests', | ||
| type: 'raw', |
| clusterTotalMemoryUsed: { | ||
| name: 'Cluster total memory used', | ||
| nameShort: 'Total memory used', | ||
| type: 'raw', |
| clusterTotalConnections: { | ||
| name: 'Cluster total connections', | ||
| nameShort: 'Total connections', | ||
| type: 'raw', |
| databaseReadRequests: { | ||
| name: 'Database read requests', | ||
| nameShort: 'Read requests', | ||
| type: 'raw', |
| databaseCacheHitRatio: { | ||
| name: 'Database cache hit ratio', | ||
| nameShort: 'Cache hit ratio', | ||
| type: 'raw', |
| databaseMemoryUtilization: { | ||
| name: 'Database memory utilization', | ||
| nameShort: 'Memory utilization', | ||
| type: 'raw', |
| expr: ||| | ||
| bdb_avg_latency / 1000 > %(alertsDatabaseHighLatencyMs)s | ||
| ||| % $._config, | ||
| bdb_avg_latency{%(filteringSelector)s} / 1000 > %(alertsDatabaseHighLatencyMs)s |
There was a problem hiding this comment.
If we divide by 1000 that would convert the value to seconds, but the alert threshold is in milliseconds - alertsDatabaseHighLatencyMs.
| + g.panel.timeSeries.standardOptions.withUnit('percent'), | ||
|
|
||
| nodesNodeCPUUtilizationPanel: | ||
| commonlib.panels.generic.timeSeries.base.new( |
There was a problem hiding this comment.
What are your thoughts on how this would look versus the commonlib.panels.cpu.timeSeries.base.new? I see that the base is empty in the common lib but it has utilization by core and mode overrides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Redis-Enterprise mixin to use the signals API to create its dashboards and follow best practices using g.libsonnet and commonlib.
If you need access for testdata we can provide it at keithschmitty.grafana.net
Screenshots with minimal setup (no loadgen so some metrics will not be populated in these screenshots)
Screenshots
OverviewNodes
Database
Logs
The way my lab was configured didn't allow for logs but it should work