chore: Modernize the Apache CouchDB mixin #1522
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dasomeone
reviewed
Nov 11, 2025
| * the prometheusWithTotal is used for backwards compatibility as some metrics are suffixed with _total but in later versions of the couchdb-mixin. | ||
| * i.e. couchdb_open_os_files_total => couchdb_open_os_files | ||
| * This is to ensure that the signals for the metrics that are suffixed with _total continue to work as expected. | ||
| * This was an identified as a noticeable change from 3.3.0 to 3.5.0 |
Member
There was a problem hiding this comment.
Thank you! 🚀
Can you call this out in the readme as well please? E.g. just what versions are supported, and what the different metricSources are for
Comment on lines
+28
to
+34
| local dashboard = presto.grafana.dashboards[fname]; | ||
| dashboard + util.patch_variables(dashboard, optional_labels) | ||
|
|
||
| for fname in std.objectFields(presto.grafana.dashboards) | ||
| }, | ||
| prometheusAlerts+:: presto.prometheus.alerts, | ||
| prometheusRules+:: presto.prometheus.recordingRules, |
Comment on lines
+5
to
+7
| local presto = | ||
| prestolib.new() | ||
| + prestolib.withConfigMixin( |
| name: 'Good response statuses', | ||
| nameShort: 'Good response statuses', | ||
| type: 'raw', | ||
| description: 'The total number of good response statuses aggregated across all nodes.', |
Member
There was a problem hiding this comment.
Suggested change
| description: 'The total number of good response statuses aggregated across all nodes.', | |
| description: 'The total number of good response (HTTP 2xx-3xx) statuses aggregated across all nodes.', |
| name: 'Error response statuses', | ||
| nameShort: 'Error response statuses', | ||
| type: 'raw', | ||
| description: 'The total number of error response statuses aggregated across all nodes.', |
Member
There was a problem hiding this comment.
Suggested change
| description: 'The total number of error response statuses aggregated across all nodes.', | |
| description: 'The total number of error response statuses (HTTP 4xx-5xx) aggregated across all nodes.', |
| errorResponseStatuses: { | ||
| name: 'Error response statuses', | ||
| nameShort: 'Error response statuses', | ||
| type: 'raw', |
Member
There was a problem hiding this comment.
This should be requests per second, right? Currently it gets rendered as "rd/s" which I see as "reads per second" which feels wrong in this context?
| goodResponseStatuses: { | ||
| name: 'Good response statuses', | ||
| nameShort: 'Good response statuses', | ||
| type: 'raw', |
Member
There was a problem hiding this comment.
This should be requests per second, right? Currently it gets rendered as "rd/s" which I see as "reads per second" which feels wrong in this context?
Comment on lines
+159
to
+198
| averageRequestLatencyp50: { | ||
| name: 'Average request latency p50', | ||
| nameShort: 'Average request latency p50', | ||
| type: 'raw', | ||
| description: 'The average request latency p50 aggregated across all nodes.', | ||
| unit: 's', | ||
| sources: { | ||
| prometheus: { | ||
| expr: 'avg by(' + groupLabelAggTerm + ', quantile) (couchdb_request_time_seconds{%(queriesSelector)s, quantile="0.5"})', | ||
| legendCustomTemplate: legendCustomTemplate + ' - p50', | ||
| }, | ||
| }, | ||
| }, | ||
|
|
||
| averageRequestLatencyp75: { | ||
| name: 'Average request latency p75', | ||
| nameShort: 'Average request latency p75', | ||
| type: 'raw', | ||
| description: 'The average request latency p75 aggregated across all nodes.', | ||
| unit: 's', | ||
| sources: { | ||
| prometheus: { | ||
| expr: 'avg by(' + groupLabelAggTerm + ', quantile) (couchdb_request_time_seconds{%(queriesSelector)s, quantile="0.75"})', | ||
| legendCustomTemplate: legendCustomTemplate + ' - p75', | ||
| }, | ||
| }, | ||
| }, | ||
|
|
||
| averageRequestLatencyp95: { | ||
| name: 'Average request latency p95', | ||
| nameShort: 'Average request latency p95', | ||
| type: 'raw', | ||
| description: 'The average request latency p95 aggregated across all nodes.', | ||
| unit: 's', | ||
| sources: { | ||
| prometheus: { | ||
| expr: 'avg by(' + groupLabelAggTerm + ', quantile) (couchdb_request_time_seconds{%(queriesSelector)s, quantile="0.95"})', | ||
| legendCustomTemplate: legendCustomTemplate + ' - p95', | ||
| }, | ||
| }, |
Member
There was a problem hiding this comment.
Same as my recent requests on the other old mixins, I think we could and should use histograms more, either as a replacement or in addition to these signals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modernizes the CouchDB Mixin to use newer libraries.
Overview
Nodes:
Logs:
