fix(AlertRuleGroup): .spec.editable cannot be be disabled (#2276)

* fix(controller/alertrulegroup_controller): set disable provenance header only if editable is true

* fix(alertrulegroup): use pointer for disableProvenance to properly control header presence

* Update controllers/alertrulegroup_controller.go

Co-authored-by: Steffen Baarsgaard <steff.bpoulsen@gmail.com>

---------

Co-authored-by: Steffen Baarsgaard <steff.bpoulsen@gmail.com>

Author: Miguel-Barros96

controllers/alertrulegroup_controller.go

@@ -118,9 +118,11 @@ func (r *GrafanaAlertRuleGroupReconciler) Reconcile(ctx context.Context, req ctr
 		return ctrl.Result{}, fmt.Errorf("folder uid not found, alert rule must reference a folder")
 	}
 
-	editable := "true" //nolint:goconst
-	if group.Spec.Editable != nil && !*group.Spec.Editable {
-		editable = "false"
+	var disableProvenance *string
+
+	if group.Spec.Editable != nil && *group.Spec.Editable {
+		trueStr := "true"
+		disableProvenance = &trueStr
 	}
 
 	mGroup := crToModel(group, folderUID)
@@ -130,7 +132,7 @@ func (r *GrafanaAlertRuleGroupReconciler) Reconcile(ctx context.Context, req ctr
 	applyErrors := make(map[string]string)
 
 	for _, grafana := range instances {
-		err := r.reconcileWithInstance(ctx, &grafana, group, &mGroup, editable)
+		err := r.reconcileWithInstance(ctx, &grafana, group, &mGroup, disableProvenance)
 		if err != nil {
 			applyErrors[fmt.Sprintf("%s/%s", grafana.Namespace, grafana.Name)] = err.Error()
 		}
@@ -214,7 +216,7 @@ func crToModel(cr *grafanav1beta1.GrafanaAlertRuleGroup, folderUID string) model
 	}
 }
 
-func (r *GrafanaAlertRuleGroupReconciler) reconcileWithInstance(ctx context.Context, instance *grafanav1beta1.Grafana, group *grafanav1beta1.GrafanaAlertRuleGroup, mGroup *models.AlertRuleGroup, disableProvenance string) error {
+func (r *GrafanaAlertRuleGroupReconciler) reconcileWithInstance(ctx context.Context, instance *grafanav1beta1.Grafana, group *grafanav1beta1.GrafanaAlertRuleGroup, mGroup *models.AlertRuleGroup, disableProvenance *string) error {
 	cl, err := client2.NewGeneratedGrafanaClient(ctx, r.Client, instance)
 	if err != nil {
 		return fmt.Errorf("building grafana client: %w", err)
@@ -260,7 +262,7 @@ func (r *GrafanaAlertRuleGroupReconciler) reconcileWithInstance(ctx context.Cont
 		if !ruleExists {
 			params := provisioning.NewPostAlertRuleParams().
 				WithBody(mRule).
-				WithXDisableProvenance(&disableProvenance)
+				WithXDisableProvenance(disableProvenance)
 
 			_, err = cl.Provisioning.PostAlertRule(params) //nolint:errcheck
 			if err != nil {
@@ -275,7 +277,7 @@ func (r *GrafanaAlertRuleGroupReconciler) reconcileWithInstance(ctx context.Cont
 		WithBody(mGroup).
 		WithGroup(mGroup.Title).
 		WithFolderUID(folderUID).
-		WithXDisableProvenance(&disableProvenance)
+		WithXDisableProvenance(disableProvenance)
 
 	_, err = cl.Provisioning.PutAlertRuleGroup(params) //nolint:errcheck
 	if err != nil {