FolderDashboardSearch params: pass in url.Values instead of map (#59)

* allow slices (map[string][]string) in search parameters

* add type assert for search params

* convert params list element to string, not just assert type

* pass in url.Values instead of map

* fix test

Author: justinTM

dashboard.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"encoding/json"
 	"fmt"
+	"net/url"
 )
 
 // DashboardMeta represents Grafana dashboard meta.
@@ -72,8 +73,8 @@ func (c *Client) NewDashboard(dashboard Dashboard) (*DashboardSaveResponse, erro
 
 // Dashboards fetches and returns all dashboards.
 func (c *Client) Dashboards() ([]FolderDashboardSearchResponse, error) {
-	params := map[string]string{
-		"type": "dash-db",
+	params := url.Values{
+		"type": {"dash-db"},
 	}
 	return c.FolderDashboardSearch(params)
 }
@@ -97,9 +98,9 @@ func (c *Client) DashboardsByIDs(ids []int64) ([]FolderDashboardSearchResponse,
 		return nil, err
 	}
 
-	params := map[string]string{
-		"type":         "dash-db",
-		"dashboardIds": string(dashboardIdsJSON),
+	params := url.Values{
+		"type":         {"dash-db"},
+		"dashboardIds": {string(dashboardIdsJSON)},
 	}
 	return c.FolderDashboardSearch(params)
 }

folder_dashboard_search.go

@@ -23,11 +23,7 @@ type FolderDashboardSearchResponse struct {
 
 // FolderDashboardSearch uses the folder and dashboard search endpoint to find
 // dashboards based on the params passed in.
-func (c *Client) FolderDashboardSearch(params map[string]string) (resp []FolderDashboardSearchResponse, err error) {
-	query := url.Values{}
-	for p, v := range params {
-		query.Add(p, v)
-	}
-	err = c.request("GET", "/api/search", query, nil, &resp)
+func (c *Client) FolderDashboardSearch(params url.Values) (resp []FolderDashboardSearchResponse, err error) {
+	err = c.request("GET", "/api/search", params, nil, &resp)
 	return
 }

folder_dashboard_search_test.go

@@ -1,6 +1,7 @@
 package gapi
 
 import (
+	"net/url"
 	"testing"
 )
 
@@ -49,7 +50,7 @@ const (
 func TestFolderDashboardSearch(t *testing.T) {
 	server, client := gapiTestTools(t, 200, getFolderDashboardSearchResponse)
 	defer server.Close()
-	resp, err := client.FolderDashboardSearch(map[string]string{})
+	resp, err := client.FolderDashboardSearch(url.Values{})
 	if err != nil {
 		t.Fatal(err)
 	}