Add string constants for resource types

Author: Aaron Godin

dashboard_permissions.go

@@ -60,18 +60,18 @@ func (c *Client) UpdateDashboardPermissionsByUID(uid string, items *PermissionIt
 }
 
 func (c *Client) ListDashboardResourcePermissions(ident ResourceIdent) ([]*ResourcePermission, error) {
-	return c.listResourcePermissions("dashboards", ident)
+	return c.listResourcePermissions(DashboardsResource, ident)
 }
 
 func (c *Client) SetDashboardResourcePermissions(ident ResourceIdent, body SetResourcePermissionsBody) (*SetResourcePermissionsResponse, error) {
-	return c.setResourcePermissions("dashboards", ident, body)
+	return c.setResourcePermissions(DashboardsResource, ident, body)
 }
 
 func (c *Client) SetUserDashboardResourcePermissions(ident ResourceIdent, userID int64, permission string) (*SetResourcePermissionsResponse, error) {
 	return c.setResourcePermissionByAssignment(
-		"dashboards",
+		DashboardsResource,
 		ident,
-		"users",
+		UsersResource,
 		ResourceID(userID),
 		SetResourcePermissionBody{
 			Permission: SetResourcePermissionItem{
@@ -84,9 +84,9 @@ func (c *Client) SetUserDashboardResourcePermissions(ident ResourceIdent, userID
 
 func (c *Client) SetTeamDashboardResourcePermissions(ident ResourceIdent, teamID int64, permission string) (*SetResourcePermissionsResponse, error) {
 	return c.setResourcePermissionByAssignment(
-		"dashboards",
+		DashboardsResource,
 		ident,
-		"teams",
+		TeamsResource,
 		ResourceID(teamID),
 		SetResourcePermissionBody{
 			Permission: SetResourcePermissionItem{
@@ -99,9 +99,9 @@ func (c *Client) SetTeamDashboardResourcePermissions(ident ResourceIdent, teamID
 
 func (c *Client) SetBuiltInRoleDashboardResourcePermissions(ident ResourceIdent, builtInRole string, permission string) (*SetResourcePermissionsResponse, error) {
 	return c.setResourcePermissionByAssignment(
-		"dashboards",
+		DashboardsResource,
 		ident,
-		"builtInRoles",
+		BuiltInRolesResource,
 		ResourceUID(builtInRole),
 		SetResourcePermissionBody{
 			Permission: SetResourcePermissionItem{

datasource_permissions.go

@@ -98,18 +98,18 @@ func (c *Client) RemoveDatasourcePermission(id, permissionID int64) error {
 }
 
 func (c *Client) ListDatasourceResourcePermissions(ident ResourceIdent) ([]*ResourcePermission, error) {
-	return c.listResourcePermissions("datasources", ident)
+	return c.listResourcePermissions(DatasourcesResource, ident)
 }
 
 func (c *Client) SetDatasourceResourcePermissions(ident ResourceIdent, body SetResourcePermissionsBody) (*SetResourcePermissionsResponse, error) {
-	return c.setResourcePermissions("datasources", ident, body)
+	return c.setResourcePermissions(DatasourcesResource, ident, body)
 }
 
 func (c *Client) SetUserDatasourceResourcePermissions(ident ResourceIdent, userID int64, permission string) (*SetResourcePermissionsResponse, error) {
 	return c.setResourcePermissionByAssignment(
-		"datasources",
+		DatasourcesResource,
 		ident,
-		"users",
+		UsersResource,
 		ResourceID(userID),
 		SetResourcePermissionBody{
 			Permission: SetResourcePermissionItem{
@@ -122,9 +122,9 @@ func (c *Client) SetUserDatasourceResourcePermissions(ident ResourceIdent, userI
 
 func (c *Client) SetTeamDatasourceResourcePermissions(ident ResourceIdent, teamID int64, permission string) (*SetResourcePermissionsResponse, error) {
 	return c.setResourcePermissionByAssignment(
-		"datasources",
+		DatasourcesResource,
 		ident,
-		"teams",
+		TeamsResource,
 		ResourceID(teamID),
 		SetResourcePermissionBody{
 			Permission: SetResourcePermissionItem{
@@ -137,9 +137,9 @@ func (c *Client) SetTeamDatasourceResourcePermissions(ident ResourceIdent, teamI
 
 func (c *Client) SetBuiltInRoleDatasourceResourcePermissions(ident ResourceIdent, builtInRole string, permission string) (*SetResourcePermissionsResponse, error) {
 	return c.setResourcePermissionByAssignment(
-		"datasources",
+		DatasourcesResource,
 		ident,
-		"builtInRoles",
+		BuiltInRolesResource,
 		ResourceUID(builtInRole),
 		SetResourcePermissionBody{
 			Permission: SetResourcePermissionItem{

folder_permissions.go

@@ -64,18 +64,18 @@ func (c *Client) UpdateFolderPermissions(fid string, items *PermissionItems) err
 }
 
 func (c *Client) ListFolderResourcePermissions(ident ResourceIdent) ([]*ResourcePermission, error) {
-	return c.listResourcePermissions("folders", ident)
+	return c.listResourcePermissions(FoldersResource, ident)
 }
 
 func (c *Client) SetFolderResourcePermissions(ident ResourceIdent, body SetResourcePermissionsBody) (*SetResourcePermissionsResponse, error) {
-	return c.setResourcePermissions("folders", ident, body)
+	return c.setResourcePermissions(FoldersResource, ident, body)
 }
 
 func (c *Client) SetUserFolderResourcePermissions(ident ResourceIdent, userID int64, permission string) (*SetResourcePermissionsResponse, error) {
 	return c.setResourcePermissionByAssignment(
-		"folders",
+		FoldersResource,
 		ident,
-		"users",
+		UsersResource,
 		ResourceID(userID),
 		SetResourcePermissionBody{
 			Permission: SetResourcePermissionItem{
@@ -88,9 +88,9 @@ func (c *Client) SetUserFolderResourcePermissions(ident ResourceIdent, userID in
 
 func (c *Client) SetTeamFolderResourcePermissions(ident ResourceIdent, teamID int64, permission string) (*SetResourcePermissionsResponse, error) {
 	return c.setResourcePermissionByAssignment(
-		"folders",
+		FoldersResource,
 		ident,
-		"teams",
+		TeamsResource,
 		ResourceID(teamID),
 		SetResourcePermissionBody{
 			Permission: SetResourcePermissionItem{
@@ -103,9 +103,9 @@ func (c *Client) SetTeamFolderResourcePermissions(ident ResourceIdent, teamID in
 
 func (c *Client) SetBuiltInRoleFolderResourcePermissions(ident ResourceIdent, builtInRole string, permission string) (*SetResourcePermissionsResponse, error) {
 	return c.setResourcePermissionByAssignment(
-		"folders",
+		FoldersResource,
 		ident,
-		"builtInRoles",
+		BuiltInRolesResource,
 		ResourceUID(builtInRole),
 		SetResourcePermissionBody{
 			Permission: SetResourcePermissionItem{

resource.go

@@ -5,6 +5,16 @@ import (
 	"strconv"
 )
 
+const (
+	DashboardsResource      = "dashboards"
+	DatasourcesResource     = "datasources"
+	FoldersResource         = "folders"
+	ServiceAccountsResource = "serviceaccounts"
+	TeamsResource           = "teams"
+	UsersResource           = "users"
+	BuiltInRolesResource    = "builtInRoles"
+)
+
 // ResourceIdent represents anything that can be considered a resource identifier.
 type ResourceIdent interface {
 	fmt.Stringer

service_account_permissions.go

@@ -1,18 +1,18 @@
 package gapi
 
 func (c *Client) ListServiceAccountResourcePermissions(ident ResourceIdent) ([]*ResourcePermission, error) {
-	return c.listResourcePermissions("serviceaccounts", ident)
+	return c.listResourcePermissions(ServiceAccountsResource, ident)
 }
 
 func (c *Client) SetServiceAccountResourcePermissions(ident ResourceIdent, body SetResourcePermissionsBody) (*SetResourcePermissionsResponse, error) {
-	return c.setResourcePermissions("serviceaccounts", ident, body)
+	return c.setResourcePermissions(ServiceAccountsResource, ident, body)
 }
 
 func (c *Client) SetUserServiceAccountResourcePermissions(ident ResourceIdent, userID int64, permission string) (*SetResourcePermissionsResponse, error) {
 	return c.setResourcePermissionByAssignment(
-		"serviceaccounts",
+		ServiceAccountsResource,
 		ident,
-		"users",
+		UsersResource,
 		ResourceID(userID),
 		SetResourcePermissionBody{
 			Permission: SetResourcePermissionItem{
@@ -25,9 +25,9 @@ func (c *Client) SetUserServiceAccountResourcePermissions(ident ResourceIdent, u
 
 func (c *Client) SetTeamServiceAccountResourcePermissions(ident ResourceIdent, teamID int64, permission string) (*SetResourcePermissionsResponse, error) {
 	return c.setResourcePermissionByAssignment(
-		"serviceaccounts",
+		ServiceAccountsResource,
 		ident,
-		"teams",
+		TeamsResource,
 		ResourceID(teamID),
 		SetResourcePermissionBody{
 			Permission: SetResourcePermissionItem{

team_permissions.go

@@ -1,18 +1,18 @@
 package gapi
 
 func (c *Client) ListTeamResourcePermissions(ident ResourceIdent) ([]*ResourcePermission, error) {
-	return c.listResourcePermissions("teams", ident)
+	return c.listResourcePermissions(TeamsResource, ident)
 }
 
 func (c *Client) SetTeamResourcePermissions(ident ResourceIdent, body SetResourcePermissionsBody) (*SetResourcePermissionsResponse, error) {
-	return c.setResourcePermissions("teams", ident, body)
+	return c.setResourcePermissions(TeamsResource, ident, body)
 }
 
 func (c *Client) SetUserTeamResourcePermissions(ident ResourceIdent, userID int64, permission string) (*SetResourcePermissionsResponse, error) {
 	return c.setResourcePermissionByAssignment(
-		"teams",
+		TeamsResource,
 		ident,
-		"users",
+		UsersResource,
 		ResourceID(userID),
 		SetResourcePermissionBody{
 			Permission: SetResourcePermissionItem{