Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Commit 513b096

Browse files
darrenjaneczekdarrenjaneczek
committed
fix: ensure panel titles are consistent
- Most existing "per second" panel titles in `main` are written "/ sec", corrected recent commits to match.
1 parent fcc4896 commit 513b096

File tree

2 files changed

+34
-34
lines changed

2 files changed

+34
-34
lines changed

‎cortex-mixin/dashboards/reads.libsonnet‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
3535
showTitle: false,
3636
})
3737
.addPanel(
38-
$.panel('Instant queries per second') +
38+
$.panel('Instant queries / sec') +
3939
$.statPanel(|||
4040
sum(
4141
rate(
@@ -66,7 +66,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
6666
),
6767
)
6868
.addPanel(
69-
$.panel('Range queries per second') +
69+
$.panel('Range queries / sec') +
7070
$.statPanel(|||
7171
sum(
7272
rate(
@@ -91,7 +91,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
9191
.addRow(
9292
$.row('Gateway')
9393
.addPanel(
94-
$.panel('Requests per second') +
94+
$.panel('Requests / sec') +
9595
$.qpsPanel('cortex_request_duration_seconds_count{%s, route=~"(prometheus|api_prom)_api_v1_.+"}' % $.jobMatcher($._config.job_names.gateway))
9696
)
9797
.addPanel(
@@ -109,7 +109,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
109109
.addRow(
110110
$.row('Query Frontend')
111111
.addPanel(
112-
$.panel('Requests per second') +
112+
$.panel('Requests / sec') +
113113
$.qpsPanel('cortex_request_duration_seconds_count{%s, route=~"(prometheus|api_prom)_api_v1_.+"}' % $.jobMatcher($._config.job_names.query_frontend))
114114
)
115115
.addPanel(
@@ -141,7 +141,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
141141
)
142142
)
143143
.addPanel(
144-
$.panel('Requests per second') +
144+
$.panel('Requests / sec') +
145145
$.qpsPanel('cortex_query_scheduler_queue_duration_seconds_count{%s}' % $.jobMatcher($._config.job_names.query_scheduler))
146146
)
147147
.addPanel(
@@ -152,7 +152,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
152152
.addRow(
153153
$.row('Cache - Query Results')
154154
.addPanel(
155-
$.panel('Requests per second') +
155+
$.panel('Requests / sec') +
156156
$.qpsPanel('cortex_cache_request_duration_seconds_count{method=~"frontend.+", %s}' % $.jobMatcher($._config.job_names.query_frontend))
157157
)
158158
.addPanel(
@@ -163,7 +163,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
163163
.addRow(
164164
$.row('Querier')
165165
.addPanel(
166-
$.panel('Requests per second') +
166+
$.panel('Requests / sec') +
167167
$.qpsPanel('cortex_querier_request_duration_seconds_count{%s, route=~"(prometheus|api_prom)_api_v1_.+"}' % $.jobMatcher($._config.job_names.querier))
168168
)
169169
.addPanel(
@@ -181,7 +181,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
181181
.addRow(
182182
$.row('Ingester')
183183
.addPanel(
184-
$.panel('Requests per second') +
184+
$.panel('Requests / sec') +
185185
$.qpsPanel('cortex_request_duration_seconds_count{%s,route=~"/cortex.Ingester/Query(Stream)?|/cortex.Ingester/MetricsForLabelMatchers|/cortex.Ingester/LabelValues|/cortex.Ingester/MetricsMetadata"}' % $.jobMatcher($._config.job_names.ingester))
186186
)
187187
.addPanel(
@@ -200,7 +200,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
200200
std.member($._config.storage_engine, 'blocks'),
201201
$.row('Store-gateway')
202202
.addPanel(
203-
$.panel('Requests per second') +
203+
$.panel('Requests / sec') +
204204
$.qpsPanel('cortex_request_duration_seconds_count{%s,route=~"/gatewaypb.StoreGateway/.*"}' % $.jobMatcher($._config.job_names.store_gateway))
205205
)
206206
.addPanel(
@@ -219,7 +219,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
219219
std.member($._config.storage_engine, 'chunks'),
220220
$.row('Memcached - Chunks storage - Index')
221221
.addPanel(
222-
$.panel('Requests per second') +
222+
$.panel('Requests / sec') +
223223
$.qpsPanel('cortex_cache_request_duration_seconds_count{%s,method="store.index-cache-read.memcache.fetch"}' % $.jobMatcher($._config.job_names.querier))
224224
)
225225
.addPanel(
@@ -231,7 +231,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
231231
std.member($._config.storage_engine, 'chunks'),
232232
$.row('Memcached - Chunks storage - Chunks')
233233
.addPanel(
234-
$.panel('Requests per second') +
234+
$.panel('Requests / sec') +
235235
$.qpsPanel('cortex_cache_request_duration_seconds_count{%s,method="chunksmemcache.fetch"}' % $.jobMatcher($._config.job_names.querier))
236236
)
237237
.addPanel(
@@ -243,7 +243,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
243243
std.member($._config.storage_engine, 'blocks'),
244244
$.row('Memcached – blocks storage – block index cache (store-gateway accesses)') // Resembles thanosMemcachedCache
245245
.addPanel(
246-
$.panel('Requests per second') +
246+
$.panel('Requests / sec') +
247247
$.queryPanel(
248248
|||
249249
sum by(operation) (
@@ -343,7 +343,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
343343
std.member($._config.chunk_index_backend + $._config.chunk_store_backend, 'cassandra'),
344344
$.row('Cassandra')
345345
.addPanel(
346-
$.panel('Requests per second') +
346+
$.panel('Requests / sec') +
347347
$.qpsPanel('cortex_cassandra_request_duration_seconds_count{%s, operation="SELECT"}' % $.jobMatcher($._config.job_names.querier))
348348
)
349349
.addPanel(
@@ -356,7 +356,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
356356
std.member($._config.chunk_index_backend + $._config.chunk_store_backend, 'bigtable'),
357357
$.row('BigTable')
358358
.addPanel(
359-
$.panel('Requests per second') +
359+
$.panel('Requests / sec') +
360360
$.qpsPanel('cortex_bigtable_request_duration_seconds_count{%s, operation="/google.bigtable.v2.Bigtable/ReadRows"}' % $.jobMatcher($._config.job_names.querier))
361361
)
362362
.addPanel(
@@ -369,7 +369,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
369369
std.member($._config.chunk_index_backend + $._config.chunk_store_backend, 'dynamodb'),
370370
$.row('DynamoDB')
371371
.addPanel(
372-
$.panel('Requests per second') +
372+
$.panel('Requests / sec') +
373373
$.qpsPanel('cortex_dynamo_request_duration_seconds_count{%s, operation="DynamoDB.QueryPages"}' % $.jobMatcher($._config.job_names.querier))
374374
)
375375
.addPanel(
@@ -382,7 +382,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
382382
std.member($._config.chunk_store_backend, 'gcs'),
383383
$.row('GCS')
384384
.addPanel(
385-
$.panel('Requests per second') +
385+
$.panel('Requests / sec') +
386386
$.qpsPanel('cortex_gcs_request_duration_seconds_count{%s, operation="GET"}' % $.jobMatcher($._config.job_names.querier))
387387
)
388388
.addPanel(

‎cortex-mixin/dashboards/writes.libsonnet‎

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
3333
showTitle: false,
3434
})
3535
.addPanel(
36-
$.panel('Samples per second') +
36+
$.panel('Samples / sec') +
3737
$.statPanel(
3838
'sum(%(group_prefix_jobs)s:cortex_distributor_received_samples:rate5m{%(job)s})' % (
3939
$._config {
@@ -59,14 +59,14 @@ local utils = import 'mixin-utils/utils.libsonnet';
5959
$.statPanel('count(count by(user) (cortex_ingester_active_series{%s}))' % $.jobMatcher($._config.job_names.ingester), format='short')
6060
)
6161
.addPanel(
62-
$.panel('Requests per second') +
62+
$.panel('Requests / sec') +
6363
$.statPanel('sum(rate(cortex_request_duration_seconds_count{%s, route=~"api_(v1|prom)_push"}[5m]))' % $.jobMatcher($._config.job_names.gateway), format='reqps')
6464
)
6565
)
6666
.addRow(
6767
$.row('Gateway')
6868
.addPanel(
69-
$.panel('Requests per second') +
69+
$.panel('Requests / sec') +
7070
$.qpsPanel('cortex_request_duration_seconds_count{%s, route=~"api_(v1|prom)_push"}' % $.jobMatcher($._config.job_names.gateway))
7171
)
7272
.addPanel(
@@ -84,7 +84,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
8484
.addRow(
8585
$.row('Distributor')
8686
.addPanel(
87-
$.panel('Requests per second') +
87+
$.panel('Requests / sec') +
8888
$.qpsPanel('cortex_request_duration_seconds_count{%s, route=~"/distributor.Distributor/Push|/httpgrpc.*|api_(v1|prom)_push"}' % $.jobMatcher($._config.job_names.distributor))
8989
)
9090
.addPanel(
@@ -102,7 +102,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
102102
.addRow(
103103
$.row('Key-value store for high-availability (HA) deduplication')
104104
.addPanel(
105-
$.panel('Requests per second') +
105+
$.panel('Requests / sec') +
106106
$.qpsPanel('cortex_kv_request_duration_seconds_count{%s}' % $.jobMatcher($._config.job_names.distributor))
107107
)
108108
.addPanel(
@@ -113,7 +113,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
113113
.addRow(
114114
$.row('Ingester')
115115
.addPanel(
116-
$.panel('Requests per second') +
116+
$.panel('Requests / sec') +
117117
$.qpsPanel('cortex_request_duration_seconds_count{%s,route="/cortex.Ingester/Push"}' % $.jobMatcher($._config.job_names.ingester))
118118
)
119119
.addPanel(
@@ -131,7 +131,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
131131
.addRow(
132132
$.row('Key-value store for the ingester ring')
133133
.addPanel(
134-
$.panel('Requests per second') +
134+
$.panel('Requests / sec') +
135135
$.qpsPanel('cortex_kv_request_duration_seconds_count{%s}' % $.jobMatcher($._config.job_names.ingester))
136136
)
137137
.addPanel(
@@ -143,7 +143,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
143143
std.member($._config.storage_engine, 'chunks'),
144144
$.row('Memcached')
145145
.addPanel(
146-
$.panel('Requests per second') +
146+
$.panel('Requests / sec') +
147147
$.qpsPanel('cortex_memcache_request_duration_seconds_count{%s,method="Memcache.Put"}' % $.jobMatcher($._config.job_names.ingester))
148148
)
149149
.addPanel(
@@ -156,7 +156,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
156156
std.member($._config.chunk_index_backend + $._config.chunk_store_backend, 'cassandra'),
157157
$.row('Cassandra')
158158
.addPanel(
159-
$.panel('Requests per second') +
159+
$.panel('Requests / sec') +
160160
$.qpsPanel('cortex_cassandra_request_duration_seconds_count{%s, operation="INSERT"}' % $.jobMatcher($._config.job_names.ingester))
161161
)
162162
.addPanel(
@@ -169,7 +169,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
169169
std.member($._config.chunk_index_backend + $._config.chunk_store_backend, 'bigtable'),
170170
$.row('BigTable')
171171
.addPanel(
172-
$.panel('Requests per second') +
172+
$.panel('Requests / sec') +
173173
$.qpsPanel('cortex_bigtable_request_duration_seconds_count{%s, operation="/google.bigtable.v2.Bigtable/MutateRows"}' % $.jobMatcher($._config.job_names.ingester))
174174
)
175175
.addPanel(
@@ -182,7 +182,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
182182
std.member($._config.chunk_index_backend + $._config.chunk_store_backend, 'dynamodb'),
183183
$.row('DynamoDB')
184184
.addPanel(
185-
$.panel('Requests per second') +
185+
$.panel('Requests / sec') +
186186
$.qpsPanel('cortex_dynamo_request_duration_seconds_count{%s, operation="DynamoDB.BatchWriteItem"}' % $.jobMatcher($._config.job_names.ingester))
187187
)
188188
.addPanel(
@@ -195,7 +195,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
195195
std.member($._config.chunk_store_backend, 'gcs'),
196196
$.row('GCS')
197197
.addPanel(
198-
$.panel('Requests per second') +
198+
$.panel('Requests / sec') +
199199
$.qpsPanel('cortex_gcs_request_duration_seconds_count{%s, operation="POST"}' % $.jobMatcher($._config.job_names.ingester))
200200
)
201201
.addPanel(
@@ -208,12 +208,12 @@ local utils = import 'mixin-utils/utils.libsonnet';
208208
$.row('Ingester - Blocks storage - Shipper')
209209
.addPanel(
210210
$.successFailurePanel(
211-
'Uploaded blocks per second',
211+
'Uploaded blocks / sec',
212212
'sum(rate(cortex_ingester_shipper_uploads_total{%s}[$__rate_interval])) - sum(rate(cortex_ingester_shipper_upload_failures_total{%s}[$__rate_interval]))' % [$.jobMatcher($._config.job_names.ingester), $.jobMatcher($._config.job_names.ingester)],
213213
'sum(rate(cortex_ingester_shipper_upload_failures_total{%s}[$__rate_interval]))' % $.jobMatcher($._config.job_names.ingester),
214214
) +
215215
$.panelDescription(
216-
'Uploaded blocks per second',
216+
'Uploaded blocks / sec',
217217
|||
218218
The rate of blocks being uploaded from the ingesters
219219
to object storage.
@@ -237,7 +237,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
237237
$.row('Ingester - Blocks storage - TSDB Head')
238238
.addPanel(
239239
$.successFailurePanel(
240-
'Compactions per second',
240+
'Compactions / sec',
241241
'sum(rate(cortex_ingester_tsdb_compactions_total{%s}[$__rate_interval]))' % [$.jobMatcher($._config.job_names.ingester)],
242242
'sum(rate(cortex_ingester_tsdb_compactions_failed_total{%s}[$__rate_interval]))' % $.jobMatcher($._config.job_names.ingester),
243243
) +
@@ -267,7 +267,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
267267
$.row('Ingester - blocks storage - TSDB write ahead log (WAL)')
268268
.addPanel(
269269
$.successFailurePanel(
270-
'WAL truncations per second',
270+
'WAL truncations / sec',
271271
'sum(rate(cortex_ingester_tsdb_wal_truncations_total{%s}[$__rate_interval])) - sum(rate(cortex_ingester_tsdb_wal_truncations_failed_total{%s}[$__rate_interval]))' % [$.jobMatcher($._config.job_names.ingester), $.jobMatcher($._config.job_names.ingester)],
272272
'sum(rate(cortex_ingester_tsdb_wal_truncations_failed_total{%s}[$__rate_interval]))' % $.jobMatcher($._config.job_names.ingester),
273273
) +
@@ -281,7 +281,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
281281
)
282282
.addPanel(
283283
$.successFailurePanel(
284-
'Checkpoints created per second',
284+
'Checkpoints created / sec',
285285
'sum(rate(cortex_ingester_tsdb_checkpoint_creations_total{%s}[$__rate_interval])) - sum(rate(cortex_ingester_tsdb_checkpoint_creations_failed_total{%s}[$__rate_interval]))' % [$.jobMatcher($._config.job_names.ingester), $.jobMatcher($._config.job_names.ingester)],
286286
'sum(rate(cortex_ingester_tsdb_checkpoint_creations_failed_total{%s}[$__rate_interval]))' % $.jobMatcher($._config.job_names.ingester),
287287
) +
@@ -306,7 +306,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
306306
),
307307
)
308308
.addPanel(
309-
$.panel('Corruptions per second') +
309+
$.panel('Corruptions / sec') +
310310
$.queryPanel([
311311
'sum(rate(cortex_ingester_wal_corruptions_total{%s}[$__rate_interval]))' % $.jobMatcher($._config.job_names.ingester),
312312
'sum(rate(cortex_ingester_tsdb_mmap_chunk_corruptions_total{%s}[$__rate_interval]))' % $.jobMatcher($._config.job_names.ingester),

0 commit comments

Comments
 (0)