Change receiver to pointer

Author: tanaka0325

kadai2/tanaka0325/imgconv/cmd/imgconv/main.go

@@ -52,7 +52,7 @@ func main() {
 				onExit(err)
 			}
 		} else {
-			fmt.Printf("%[1]s.%[2]s => %[1]s.%[3]s\n", param.File.Path, param.FromExt, param.ToExt)
+			fmt.Printf("%[1]s.%[2]s => %[1]s.%[3]s\n", param.File.GetPath(), param.FromExt, param.ToExt)
 		}
 	}
 }

kadai2/tanaka0325/imgconv/file.go

@@ -8,15 +8,17 @@ import (
 type OpenCreator interface {
 	Open() (io.ReadCloser, error)
 	Create() (io.WriteCloser, error)
+	GetPath() string
 }
 
 type File struct {
 	Path string
 }
 
-func (f File) Open() (io.ReadCloser, error)    { return os.Open(f.Path) }
-func (f File) Create() (io.WriteCloser, error) { return os.Create(f.Path) }
+func (f *File) Open() (io.ReadCloser, error)    { return os.Open(f.Path) }
+func (f *File) Create() (io.WriteCloser, error) { return os.Create(f.Path) }
+func (f *File) GetPath() string                 { return f.Path }
 
-func NewFile(p string) File {
-	return File{Path: p}
+func NewFile(p string) *File {
+	return &File{Path: p}
 }

kadai2/tanaka0325/imgconv/image.go

@@ -29,52 +29,52 @@ type Image struct{}
 // ImagePng is type for png format.
 type ImagePNG Image
 
-func (ip ImagePNG) Decode(r io.Reader) (image.Image, error) { return png.Decode(r) }
+func (ip *ImagePNG) Decode(r io.Reader) (image.Image, error) { return png.Decode(r) }
 
-func (ip ImagePNG) Encode(w io.Writer, i image.Image) error { return png.Encode(w, i) }
+func (ip *ImagePNG) Encode(w io.Writer, i image.Image) error { return png.Encode(w, i) }
 
 // ImageJPEG is type for jpeg format.
 type ImageJPEG Image
 
-func (ip ImageJPEG) Decode(r io.Reader) (image.Image, error) { return jpeg.Decode(r) }
+func (ip *ImageJPEG) Decode(r io.Reader) (image.Image, error) { return jpeg.Decode(r) }
 
-func (ip ImageJPEG) Encode(w io.Writer, i image.Image) error { return jpeg.Encode(w, i, nil) }
+func (ip *ImageJPEG) Encode(w io.Writer, i image.Image) error { return jpeg.Encode(w, i, nil) }
 
 // ImageGIF is type for gif format.
 type ImageGIF Image
 
-func (ip ImageGIF) Decode(r io.Reader) (image.Image, error) { return gif.Decode(r) }
+func (ip *ImageGIF) Decode(r io.Reader) (image.Image, error) { return gif.Decode(r) }
 
-func (ip ImageGIF) Encode(w io.Writer, i image.Image) error {
+func (ip *ImageGIF) Encode(w io.Writer, i image.Image) error {
 	return gif.Encode(w, i, &gif.Options{NumColors: 256})
 }
 
 // ImageBMP is type for bmp format.
 type ImageBMP Image
 
-func (ip ImageBMP) Decode(r io.Reader) (image.Image, error) { return bmp.Decode(r) }
+func (ip *ImageBMP) Decode(r io.Reader) (image.Image, error) { return bmp.Decode(r) }
 
-func (ip ImageBMP) Encode(w io.Writer, i image.Image) error { return bmp.Encode(w, i) }
+func (ip *ImageBMP) Encode(w io.Writer, i image.Image) error { return bmp.Encode(w, i) }
 
 // ImageTIFF is type for tiff format.
 type ImageTIFF Image
 
-func (ip ImageTIFF) Decode(r io.Reader) (image.Image, error) { return tiff.Decode(r) }
+func (ip *ImageTIFF) Decode(r io.Reader) (image.Image, error) { return tiff.Decode(r) }
 
-func (ip ImageTIFF) Encode(w io.Writer, i image.Image) error { return tiff.Encode(w, i, nil) }
+func (ip *ImageTIFF) Encode(w io.Writer, i image.Image) error { return tiff.Encode(w, i, nil) }
 
 func NewImage(ext string) DecodeEncoder {
 	switch ext {
 	case "png":
-		return ImagePNG{}
+		return &ImagePNG{}
 	case "jpg", "jpeg":
-		return ImageJPEG{}
+		return &ImageJPEG{}
 	case "gif":
-		return ImageGIF{}
+		return &ImageGIF{}
 	case "bmp":
-		return ImageBMP{}
+		return &ImageBMP{}
 	case "tiff", "tif":
-		return ImageTIFF{}
+		return &ImageTIFF{}
 	}
 
 	return nil

kadai2/tanaka0325/imgconv/imgconv.go

@@ -2,7 +2,7 @@
 package imgconv
 
 type ConvertParam struct {
-	File        File
+	File        OpenCreator
 	BeforeImage Decoder
 	AfterImage  Encoder
 	FromExt     string