Skip to content

Commit e238797

Browse files
chore: update and fix logback versions used in test (#3990)
These are test only dependencies, dependabot [alerts](https://github.com/googleapis/sdk-platform-java/security/dependabot?q=package%3Ach.qos.logback%3Alogback-core+manifest%3Ajava-showcase%2Fgapic-showcase%2Fpom.xml+has%3Apatch) should not matter as code is not shipped and test is in controlled env. However, it is good practice to update versions when possible. --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent 1527374 commit e238797

File tree

1 file changed

+6
-4
lines changed
  • java-showcase/gapic-showcase

1 file changed

+6
-4
lines changed

java-showcase/gapic-showcase/pom.xml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@
1818

1919
<properties>
2020
<gapic-showcase.version>0.36.2</gapic-showcase.version>
21+
<!-- This is the last version supporting slf4j 1.x, do not upgrade -->
2122
<slf4j1-logback.version>1.2.13</slf4j1-logback.version>
23+
<slf4j2-logback.version>1.5.21</slf4j2-logback.version>
2224
</properties>
2325

2426
<build>
@@ -244,13 +246,13 @@
244246
<dependency>
245247
<groupId>ch.qos.logback</groupId>
246248
<artifactId>logback-classic</artifactId>
247-
<version>1.5.16</version>
249+
<version>${slf4j2-logback.version}</version>
248250
<scope>test</scope>
249251
</dependency>
250252
<dependency>
251253
<groupId>ch.qos.logback</groupId>
252254
<artifactId>logback-core</artifactId>
253-
<version>1.5.16</version>
255+
<version>${slf4j2-logback.version}</version>
254256
<scope>test</scope>
255257
</dependency>
256258
</dependencies>
@@ -333,13 +335,13 @@
333335
<dependency>
334336
<groupId>ch.qos.logback</groupId>
335337
<artifactId>logback-classic</artifactId>
336-
<version>1.2.13</version>
338+
<version>${slf4j1-logback.version}</version>
337339
<scope>test</scope>
338340
</dependency>
339341
<dependency>
340342
<groupId>ch.qos.logback</groupId>
341343
<artifactId>logback-core</artifactId>
342-
<version>1.3.15</version>
344+
<version>${slf4j1-logback.version}</version>
343345
<scope>test</scope>
344346
</dependency>
345347
</dependencies>

0 commit comments

Comments
 (0)