Skip to content

Commit d2ff046

Browse files
authored
feat: add gcp client attributes for Opentelemetry traces (#2215)
1 parent 9f77f9f commit d2ff046

File tree

2 files changed

+21
-0
lines changed

2 files changed

+21
-0
lines changed

observability-test/observability.ts

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,24 @@ describe('startTrace', () => {
142142
'Missing OTEL_SCOPE_VERSION attribute'
143143
);
144144

145+
assert.equal(
146+
span.attributes['gcp.client.service'],
147+
'spanner',
148+
'Missing gcp.client.service attribute'
149+
);
150+
151+
assert.equal(
152+
span.attributes['gcp.client.version'],
153+
TRACER_VERSION,
154+
'Missing gcp.client.version attribute'
155+
);
156+
157+
assert.equal(
158+
span.attributes['gcp.client.repo'],
159+
'googleapis/nodejs-spanner',
160+
'Missing gcp.client.repo attribute'
161+
);
162+
145163
assert.equal(
146164
span.attributes[SEMATTRS_DB_SYSTEM],
147165
'spanner',

src/instrument.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,9 @@ export function startTrace<T>(
144144
span.setAttribute(SEMATTRS_DB_SYSTEM, 'spanner');
145145
span.setAttribute(ATTR_OTEL_SCOPE_NAME, TRACER_NAME);
146146
span.setAttribute(ATTR_OTEL_SCOPE_VERSION, TRACER_VERSION);
147+
span.setAttribute('gcp.client.service', 'spanner');
148+
span.setAttribute('gcp.client.version', TRACER_VERSION);
149+
span.setAttribute('gcp.client.repo', 'googleapis/nodejs-spanner');
147150

148151
if (config.tableName) {
149152
span.setAttribute(SEMATTRS_DB_SQL_TABLE, config.tableName);

0 commit comments

Comments
 (0)