Enable and fix unnecessary_ignore lint (#1477)

kevmoo · web-flow · commit 51c214246f15 · 2025-02-06T13:46:42.000-08:00
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -26,3 +26,4 @@ linter:
     - unnecessary_breaks
     - use_full_hex_values_for_flutter_colors
     - use_string_buffers
+    - unnecessary_ignore
diff --git a/json_serializable/lib/src/type_helpers/json_converter_helper.dart b/json_serializable/lib/src/type_helpers/json_converter_helper.dart
@@ -214,7 +214,6 @@ _JsonConvertData? _typeConverterFrom(
 
   final annotationElement = match.elementAnnotation?.element;
   if (annotationElement is PropertyAccessorElement) {
-    // ignore: deprecated_member_use
     final enclosing = annotationElement.enclosingElement3;
 
     var accessString = annotationElement.name;
diff --git a/json_serializable/lib/src/utils.dart b/json_serializable/lib/src/utils.dart
@@ -131,7 +131,6 @@ ConstructorElement? _constructorByNameOrNull(
 ) {
   try {
     return constructorByName(classElement, name);
-    // ignore: avoid_catching_errors
   } on InvalidGenerationSourceError {
     return null;
   }
diff --git a/json_serializable/test/supported_types/extra_map_test.dart b/json_serializable/test/supported_types/extra_map_test.dart
@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: prefer_const_declarations
 @TestOn('vm')
 library;
 
diff --git a/json_serializable/test/supported_types/type_test.bigint_test.dart b/json_serializable/test/supported_types/type_test.bigint_test.dart
@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: prefer_const_declarations
 @TestOn('vm')
 library;
 
@@ -87,8 +86,8 @@ void main() {
   }); // end nullable group
 }
 
-final _defaultValue = '12345';
-final _altValue = '67890';
+const _defaultValue = '12345';
+const _altValue = '67890';
 
 final _defaultInput = <String, Object?>{
   'value': _defaultValue,
diff --git a/json_serializable/test/supported_types/type_test.bool_test.dart b/json_serializable/test/supported_types/type_test.bool_test.dart
@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: prefer_const_declarations
 @TestOn('vm')
 library;
 
@@ -87,8 +86,8 @@ void main() {
   }); // end nullable group
 }
 
-final _defaultValue = true;
-final _altValue = false;
+const _defaultValue = true;
+const _altValue = false;
 
 final _defaultInput = <String, Object?>{
   'value': _defaultValue,
diff --git a/json_serializable/test/supported_types/type_test.dart b/json_serializable/test/supported_types/type_test.dart
@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: prefer_const_declarations
 @TestOn('vm')
 library;
 
@@ -53,8 +52,8 @@ void main() {
   }); // end non-nullable group
 }
 
-final _defaultValue = 42;
-final _altValue = 43;
+const _defaultValue = 42;
+const _altValue = 43;
 
 final _defaultInput = <String, Object?>{
   'value': _defaultValue,
diff --git a/json_serializable/test/supported_types/type_test.datetime_test.dart b/json_serializable/test/supported_types/type_test.datetime_test.dart
@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: prefer_const_declarations
 @TestOn('vm')
 library;
 
@@ -87,8 +86,8 @@ void main() {
   }); // end nullable group
 }
 
-final _defaultValue = '2020-01-01T00:00:00.000';
-final _altValue = '2018-01-01T00:00:00.000';
+const _defaultValue = '2020-01-01T00:00:00.000';
+const _altValue = '2018-01-01T00:00:00.000';
 
 final _defaultInput = <String, Object?>{
   'value': _defaultValue,
diff --git a/json_serializable/test/supported_types/type_test.double_test.dart b/json_serializable/test/supported_types/type_test.double_test.dart
@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: prefer_const_declarations
 @TestOn('vm')
 library;
 
@@ -87,8 +86,8 @@ void main() {
   }); // end nullable group
 }
 
-final _defaultValue = 3.14;
-final _altValue = 6.28;
+const _defaultValue = 3.14;
+const _altValue = 6.28;
 
 final _defaultInput = <String, Object?>{
   'value': _defaultValue,
diff --git a/json_serializable/test/supported_types/type_test.duration_test.dart b/json_serializable/test/supported_types/type_test.duration_test.dart
@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: prefer_const_declarations
 @TestOn('vm')
 library;
 
@@ -87,8 +86,8 @@ void main() {
   }); // end nullable group
 }
 
-final _defaultValue = 1234;
-final _altValue = 2345;
+const _defaultValue = 1234;
+const _altValue = 2345;
 
 final _defaultInput = <String, Object?>{
   'value': _defaultValue,
diff --git a/json_serializable/test/supported_types/type_test.enumtype_test.dart b/json_serializable/test/supported_types/type_test.enumtype_test.dart
@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: prefer_const_declarations
 @TestOn('vm')
 library;
 
@@ -87,8 +86,8 @@ void main() {
   }); // end nullable group
 }
 
-final _defaultValue = 'alpha';
-final _altValue = 'beta';
+const _defaultValue = 'alpha';
+const _altValue = 'beta';
 
 final _defaultInput = <String, Object?>{
   'value': _defaultValue,
diff --git a/json_serializable/test/supported_types/type_test.int_test.dart b/json_serializable/test/supported_types/type_test.int_test.dart
@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: prefer_const_declarations
 @TestOn('vm')
 library;
 
@@ -87,8 +86,8 @@ void main() {
   }); // end nullable group
 }
 
-final _defaultValue = 42;
-final _altValue = 43;
+const _defaultValue = 42;
+const _altValue = 43;
 
 final _defaultInput = <String, Object?>{
   'value': _defaultValue,
diff --git a/json_serializable/test/supported_types/type_test.iterable_test.dart b/json_serializable/test/supported_types/type_test.iterable_test.dart
@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: prefer_const_declarations
 @TestOn('vm')
 library;
 
@@ -87,8 +86,8 @@ void main() {
   }); // end nullable group
 }
 
-final _defaultValue = [42, true, false, null];
-final _altValue = [43, false];
+const _defaultValue = [42, true, false, null];
+const _altValue = [43, false];
 
 final _defaultInput = <String, Object?>{
   'value': _defaultValue,
diff --git a/json_serializable/test/supported_types/type_test.list_test.dart b/json_serializable/test/supported_types/type_test.list_test.dart
@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: prefer_const_declarations
 @TestOn('vm')
 library;
 
@@ -87,8 +86,8 @@ void main() {
   }); // end nullable group
 }
 
-final _defaultValue = [42, true, false, null];
-final _altValue = [43, false];
+const _defaultValue = [42, true, false, null];
+const _altValue = [43, false];
 
 final _defaultInput = <String, Object?>{
   'value': _defaultValue,
diff --git a/json_serializable/test/supported_types/type_test.map_test.dart b/json_serializable/test/supported_types/type_test.map_test.dart
@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: prefer_const_declarations
 @TestOn('vm')
 library;
 
@@ -87,8 +86,8 @@ void main() {
   }); // end nullable group
 }
 
-final _defaultValue = {'a': 1};
-final _altValue = {'b': 2};
+const _defaultValue = {'a': 1};
+const _altValue = {'b': 2};
 
 final _defaultInput = <String, Object?>{
   'value': _defaultValue,
diff --git a/json_serializable/test/supported_types/type_test.num_test.dart b/json_serializable/test/supported_types/type_test.num_test.dart
@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: prefer_const_declarations
 @TestOn('vm')
 library;
 
@@ -87,8 +86,8 @@ void main() {
   }); // end nullable group
 }
 
-final _defaultValue = 88.6;
-final _altValue = 29;
+const _defaultValue = 88.6;
+const _altValue = 29;
 
 final _defaultInput = <String, Object?>{
   'value': _defaultValue,
diff --git a/json_serializable/test/supported_types/type_test.object_test.dart b/json_serializable/test/supported_types/type_test.object_test.dart
@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: prefer_const_declarations
 @TestOn('vm')
 library;
 
@@ -87,8 +86,8 @@ void main() {
   }); // end nullable group
 }
 
-final _defaultValue = 'o1';
-final _altValue = 'o2';
+const _defaultValue = 'o1';
+const _altValue = 'o2';
 
 final _defaultInput = <String, Object?>{
   'value': _defaultValue,
diff --git a/json_serializable/test/supported_types/type_test.set_test.dart b/json_serializable/test/supported_types/type_test.set_test.dart
@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: prefer_const_declarations
 @TestOn('vm')
 library;
 
@@ -87,8 +86,8 @@ void main() {
   }); // end nullable group
 }
 
-final _defaultValue = [42, true, false, null];
-final _altValue = [43, false];
+const _defaultValue = [42, true, false, null];
+const _altValue = [43, false];
 
 final _defaultInput = <String, Object?>{
   'value': _defaultValue,
diff --git a/json_serializable/test/supported_types/type_test.string_test.dart b/json_serializable/test/supported_types/type_test.string_test.dart
@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: prefer_const_declarations
 @TestOn('vm')
 library;
 
@@ -87,8 +86,8 @@ void main() {
   }); // end nullable group
 }
 
-final _defaultValue = 'a string';
-final _altValue = 'another string';
+const _defaultValue = 'a string';
+const _altValue = 'another string';
 
 final _defaultInput = <String, Object?>{
   'value': _defaultValue,
diff --git a/json_serializable/test/supported_types/type_test.uri_test.dart b/json_serializable/test/supported_types/type_test.uri_test.dart
@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// ignore_for_file: prefer_const_declarations
 @TestOn('vm')
 library;
 
@@ -87,8 +86,8 @@ void main() {
   }); // end nullable group
 }
 
-final _defaultValue = 'https://example.com';
-final _altValue = 'https://dart.dev';
+const _defaultValue = 'https://example.com';
+const _altValue = 'https://dart.dev';
 
 final _defaultInput = <String, Object?>{
   'value': _defaultValue,
diff --git a/json_serializable/tool/test_type_data.dart b/json_serializable/tool/test_type_data.dart
@@ -242,12 +242,12 @@ class TestTypeData {
 
     yield Replacement(
       '''
-final _defaultValue = 42;
-final _altValue = 43;
+const _defaultValue = 42;
+const _altValue = 43;
 ''',
       '''
-final _defaultValue = $jsonExpression;
-final _altValue = $altJsonExpression;
+const _defaultValue = $jsonExpression;
+const _altValue = $altJsonExpression;
 ''',
     );
 

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,6 @@ ConstructorElement? _constructorByNameOrNull(`
`131`	`131`	`) {`
`132`	`132`	`try {`
`133`	`133`	`return constructorByName(classElement, name);`
`134`		`- // ignore: avoid_catching_errors`
`135`	`134`	`} on InvalidGenerationSourceError {`
`136`	`135`	`return null;`
`137`	`136`	`}`