Skip to content

Commit 8213f69

Browse files
milantracygvisor-bot
authored andcommitted
Run containerd integration tests with all supported containerd major versions.
The major supported versions are: 1.6, 1.7, 2.0 PiperOrigin-RevId: 831559954
1 parent ac46fb4 commit 8213f69

File tree

3 files changed

+40
-32
lines changed

3 files changed

+40
-32
lines changed

.buildkite/pipeline.yaml

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -429,6 +429,7 @@ steps:
429429
arch: "amd64"
430430
- <<: *common
431431
<<: *docker
432+
<<: *source_test
432433
label: ":docker: Containerd 1.6.2 tests (cgroupv1)"
433434
command: make containerd-test-1.6.2
434435
agents:
@@ -443,6 +444,44 @@ steps:
443444
agents:
444445
<<: *ubuntu_agents
445446
cgroup: "v2"
447+
- <<: *common
448+
<<: *docker
449+
<<: *source_test
450+
label: ":docker: Containerd 1.7.25 tests (cgroupv1)"
451+
command: make containerd-test-1.7.25
452+
agents:
453+
<<: *platform_specific_agents
454+
<<: *ubuntu_agents
455+
cgroup: "v1"
456+
kernel: "modern"
457+
- <<: *common
458+
<<: *docker
459+
<<: *source_test
460+
label: ":docker: Containerd 1.7.25 tests (cgroupv2)"
461+
command: make containerd-test-1.7.25
462+
agents:
463+
<<: *ubuntu_agents
464+
cgroup: "v2"
465+
kernel: "modern"
466+
- <<: *common
467+
<<: *docker
468+
<<: *source_test
469+
label: ":docker: Containerd 2.0.6 tests (cgroupv1)"
470+
command: make containerd-test-2.0.6
471+
agents:
472+
<<: *platform_specific_agents
473+
<<: *ubuntu_agents
474+
cgroup: "v1"
475+
kernel: "modern"
476+
- <<: *common
477+
<<: *docker
478+
<<: *source_test
479+
label: ":docker: Containerd 2.0.6 tests (cgroupv2)"
480+
command: make containerd-test-2.0.6
481+
agents:
482+
<<: *ubuntu_agents
483+
cgroup: "v2"
484+
kernel: "modern"
446485
- <<: *common
447486
<<: *source_test
448487
label: ":podman: Podman"

Makefile

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -470,19 +470,7 @@ else
470470
sudo tar -C "$$(dirname $$(which containerd))" -zxvf - containerd-shim-runsc-v1
471471
endif
472472
@$(call sudo,test/root:root_test,--runtime=$(RUNTIME) -test.v)
473-
containerd-tests-min: containerd-test-1.4.12
474-
475-
##
476-
## Containerd tests.
477-
##
478-
## Runs all supported containerd version tests. Update as new versions become
479-
## available.
480-
##
481-
containerd-tests:
482-
containerd-tests: containerd-test-1.4.12
483-
containerd-tests: containerd-test-1.5.11
484-
containerd-tests: containerd-test-1.6.2
485-
containerd-tests: containerd-test-1.7.25
473+
containerd-tests-min: containerd-test-1.6.2
486474

487475
##
488476
## Benchmarks.

test/root/crictl_test.go

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -269,22 +269,6 @@ func TestHomeDir(t *testing.T) {
269269

270270
const containerdRuntime = "runsc"
271271

272-
// containerdConfigv14 is the containerd (1.4-) configuration file that
273-
// configures the gVisor shim.
274-
//
275-
// Note that the v2 shim binary name must be containerd-shim-<runtime>-v1.
276-
const containerdConfigv14 = `
277-
disabled_plugins = ["restart"]
278-
[plugins.cri]
279-
disable_tcp_service = true
280-
[plugins.linux]
281-
shim_debug = true
282-
[plugins.cri.containerd.runtimes.` + containerdRuntime + `]
283-
runtime_type = "io.containerd.` + containerdRuntime + `.v1"
284-
[plugins.cri.containerd.runtimes.` + containerdRuntime + `.options]
285-
TypeUrl = "io.containerd.` + containerdRuntime + `.v1.options"
286-
`
287-
288272
// containerdConfig is the containerd (1.5+) configuration file that
289273
// configures the gVisor shim.
290274
//
@@ -496,8 +480,5 @@ func getContainerd() string {
496480
}
497481

498482
func getContainerdConfig(major, minor uint64) string {
499-
if major == 1 && minor <= 4 {
500-
return containerdConfigv14
501-
}
502483
return containerdConfig
503484
}

0 commit comments

Comments
 (0)