Skip to content

Commit 61f4c77

Browse files
manninglucasgvisor-bot
authored andcommitted
Don't log warnings for incomplete Release requests in FUSE.
These are harmless errors, they generally happen as the test env is being taken down. Linux does not check for the result of these requests either. Logging a warning will cause tests to fail occasionally. PiperOrigin-RevId: 821811305
1 parent 2427424 commit 61f4c77

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

pkg/sentry/fsimpl/fuse/file.go

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import (
1919
"gvisor.dev/gvisor/pkg/atomicbitops"
2020
"gvisor.dev/gvisor/pkg/context"
2121
"gvisor.dev/gvisor/pkg/errors/linuxerr"
22-
"gvisor.dev/gvisor/pkg/log"
2322
"gvisor.dev/gvisor/pkg/sentry/fsimpl/kernfs"
2423
"gvisor.dev/gvisor/pkg/sentry/kernel/auth"
2524
"gvisor.dev/gvisor/pkg/sentry/vfs"
@@ -92,14 +91,7 @@ func (fd *fileDescription) Release(ctx context.Context) {
9291
// Ignoring errors and FUSE server replies is analogous to Linux's behavior.
9392
req := conn.NewRequest(auth.CredentialsFromContext(ctx), pidFromContext(ctx), inode.nodeID, opcode, &in)
9493
// The reply will be ignored since no callback is defined in asyncCallBack().
95-
res, err := conn.Call(ctx, req)
96-
if err != nil {
97-
log.Warningf("FUSE Release failed: %v", err)
98-
return
99-
}
100-
if res.Error() != nil {
101-
log.Warningf("FUSE Release failed: %v", res.Error())
102-
}
94+
conn.Call(ctx, req)
10395
}
10496

10597
// OnClose implements vfs.FileDescriptionImpl.OnClose.

0 commit comments

Comments
 (0)