Skip to content

Commit 14ff9ab

Browse files
ayushr2gvisor-bot
authored andcommitted
gpu: Remove --cuda_verify_compatibility flag.
CUDA tests run in reasonable time with this flag enabled as well. Remove this flag (hence enabling it be default) so that we catch any test compatibility issues on pre-submits. PiperOrigin-RevId: 796618710
1 parent fc2f4df commit 14ff9ab

File tree

3 files changed

+6
-14
lines changed

3 files changed

+6
-14
lines changed

.buildkite/release.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ steps:
8585
<<: *retry_settings
8686
commands:
8787
- make sudo TARGETS=//tools/gpu:main ARGS="install --latest" || cat /var/log/nvidia-installer.log
88-
- make cuda-tests ARGS="--cuda_verify_compatibility=true"
88+
- make cuda-tests
8989
agents:
9090
queue: gpu
9191
- label: ":batfish: CUDA 12.8 tests"
@@ -97,7 +97,7 @@ steps:
9797
<<: *retry_settings
9898
commands:
9999
- make sudo TARGETS=//tools/gpu:main ARGS="install --latest" || cat /var/log/nvidia-installer.log
100-
- make cuda-12-8-tests ARGS="--cuda_verify_compatibility=true"
100+
- make cuda-12-8-tests
101101
agents:
102102
queue: gpu
103103
- <<: *common

test/gpu/cuda/cuda.go

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,9 @@ const (
6363

6464
// Flags.
6565
var (
66-
verifyCompatibility = flag.Bool("cuda_verify_compatibility", os.Getenv("GVISOR_TEST_CUDA_VERIFY_COMPATIBILITY") == "true", "whether to verify that all tests are marked as compatible")
67-
logSuccessfulTests = flag.Bool("cuda_log_successful_tests", false, "log console output of successful tests")
68-
debug = flag.Bool("cuda_test_debug", false, "log more data as the test is running")
69-
containersPerCPU = flag.Float64("cuda_containers_per_cpu", defaultContainersPerCPU, "number of parallel execution containers to spawn per CPU (floating point values allowed)")
66+
logSuccessfulTests = flag.Bool("cuda_log_successful_tests", false, "log console output of successful tests")
67+
debug = flag.Bool("cuda_test_debug", false, "log more data as the test is running")
68+
containersPerCPU = flag.Float64("cuda_containers_per_cpu", defaultContainersPerCPU, "number of parallel execution containers to spawn per CPU (floating point values allowed)")
7069
)
7170

7271
// InitFlags parses the flags and sets the test.parallel flag to the desired
@@ -524,9 +523,6 @@ func runSampleTest(ctx context.Context, t *testing.T, testName string, te *TestE
524523
compat = &FullyCompatible{}
525524
}
526525
willFailReason := compat.WillFail(ctx, te)
527-
if willFailReason != "" && !*verifyCompatibility {
528-
return fmt.Sprintf("this test is expected to fail (%s) --cuda_verify_compatibility=true to verify compatibility)", willFailReason), nil
529-
}
530526
if skipReason, isAlwaysSkipped := args.AlwaysSkippedTests[testName]; isAlwaysSkipped {
531527
return fmt.Sprintf("this test is always skipped (%v)", skipReason), nil
532528
}
@@ -676,8 +672,7 @@ type RunCudaTestArgs struct {
676672
// parallel with them.
677673
ExclusiveTests map[string]struct{}
678674

679-
// AlwaysSkippedTests don't run at all, ever, and are not verified when
680-
// --cuda_verify_compatibility is set.
675+
// AlwaysSkippedTests don't run at all.
681676
// Each test is mapped to a reason why it should be skipped.
682677
AlwaysSkippedTests map[string]string
683678

test/gpu/cuda_12_8_test.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,6 @@ var flakyTests = map[string]struct{}{}
3535

3636
var exclusiveTests = map[string]struct{}{}
3737

38-
// alwaysSkippedTests don't run at all, ever, and are not verified when
39-
// --cuda_verify_compatibility is set.
40-
// Each test is mapped to a reason why it should be skipped.
4138
// TODO(zkoopmans): Enable these tests once they pass.
4239
var alwaysSkippedTests = map[string]string{
4340
"4_CUDA_Libraries/cudaNvSci": "TODO - Debug",

0 commit comments

Comments
 (0)