Make result_of explain the inner matcher failure
#539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, `explain_match()` ends up calling the inner matcher's
`describe()`. Although this works just fine for simple matchers, it
falls apart for more complex ones, as it'll merely describe the matcher
itself without including relevant intermediate values. For instance,
this:
```rust
assert_that!(2, result_of!(|n| n, property!(i32.ilog2(), eq(10))));
```
results in:
```
Actual: 2,
which, results into 2
by applying |n| n,
has property `ilog2()`, which isn't equal to 10
```
which omits the actual result of invoking the property.
By having it invoke `explain_match()`, we instead get the complete
explanation:
```
Actual: 2,
which, results into 2
by applying |n| n,
whose property `ilog2()` is `1`, which isn't equal to 10
```
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
@refi64 Assigning back to you to resolve the CLA issue. |
gribozavr
reviewed
Feb 17, 2025
| Description::new() | ||
| .text(format!("which, results into {actual_result:?}",)) | ||
| .nested(self.describe(self.matches(actual))) | ||
| Description::new().text(format!("which, results into {actual_result:?}")).nested( |
Collaborator
There was a problem hiding this comment.
Could you add a test that demonstrates the new behavior?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now,
explain_match()ends up calling the inner matcher'sdescribe(). Although this works just fine for simple matchers, it falls apart for more complex ones, as it'll merely describe the matcher itself without including relevant intermediate values. For instance, this:results in:
which omits the actual result of invoking the property.
By having it invoke
explain_match(), we instead get the complete explanation: