Skip to content

Commit 1b465a6

Browse files
l46kokcopybara-github
authored andcommitted
Remove no-op evaluateCanonicalTypesToNativeValues flag in tests
PiperOrigin-RevId: 828187012
1 parent 0c00aaa commit 1b465a6

File tree

9 files changed

+7
-30
lines changed

9 files changed

+7
-30
lines changed

bundle/src/test/java/dev/cel/bundle/CelImplTest.java

Lines changed: 4 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -817,7 +817,6 @@ public void program_messageConstruction() throws Exception {
817817
public void program_duplicateTypeDescriptor() throws Exception {
818818
Cel cel =
819819
standardCelBuilderWithMacros()
820-
.setOptions(CelOptions.current().evaluateCanonicalTypesToNativeValues(true).build())
821820
.addMessageTypes(Timestamp.getDescriptor())
822821
.addMessageTypes(ImmutableList.of(Timestamp.getDescriptor()))
823822
.setContainer(CelContainer.ofName("google"))
@@ -833,7 +832,6 @@ public void program_duplicateTypeDescriptor() throws Exception {
833832
public void program_hermeticDescriptors_wellKnownProtobuf() throws Exception {
834833
Cel cel =
835834
standardCelBuilderWithMacros()
836-
.setOptions(CelOptions.current().evaluateCanonicalTypesToNativeValues(true).build())
837835
.addMessageTypes(Timestamp.getDescriptor())
838836
.setContainer(CelContainer.ofName("google"))
839837
.setResultType(SimpleType.TIMESTAMP)
@@ -962,7 +960,6 @@ public void program_deepTypeResolutionDisabledForRuntime_fails() throws Exceptio
962960
public void program_typeProvider() throws Exception {
963961
Cel cel =
964962
standardCelBuilderWithMacros()
965-
.setOptions(CelOptions.current().evaluateCanonicalTypesToNativeValues(true).build())
966963
.setTypeProvider(
967964
new DescriptorTypeProvider(ImmutableList.of(Timestamp.getDescriptor())))
968965
.setContainer(CelContainer.ofName("google"))
@@ -1029,10 +1026,7 @@ public void program_enumTypeReferenceResolution(boolean resolveTypeDependencies)
10291026
Cel cel =
10301027
standardCelBuilderWithMacros()
10311028
.setOptions(
1032-
CelOptions.current()
1033-
.evaluateCanonicalTypesToNativeValues(true)
1034-
.resolveTypeDependencies(resolveTypeDependencies)
1035-
.build())
1029+
CelOptions.current().resolveTypeDependencies(resolveTypeDependencies).build())
10361030
.addMessageTypes(Struct.getDescriptor())
10371031
.setResultType(StructTypeReference.create("google.protobuf.NullValue"))
10381032
.setContainer(CelContainer.ofName("google.protobuf"))
@@ -1050,11 +1044,7 @@ public void program_enumTypeReferenceResolution(boolean resolveTypeDependencies)
10501044
public void program_enumTypeTransitiveResolution() throws Exception {
10511045
Cel cel =
10521046
standardCelBuilderWithMacros()
1053-
.setOptions(
1054-
CelOptions.current()
1055-
.evaluateCanonicalTypesToNativeValues(true)
1056-
.resolveTypeDependencies(true)
1057-
.build())
1047+
.setOptions(CelOptions.current().resolveTypeDependencies(true).build())
10581048
.addMessageTypes(Proto2ExtensionScopedMessage.getDescriptor())
10591049
.setResultType(StructTypeReference.create("google.protobuf.NullValue"))
10601050
.setContainer(CelContainer.ofName("google.protobuf"))
@@ -1643,11 +1633,7 @@ public void programAdvanceEvaluation_indexOnUnknownContainer() throws Exception
16431633
public void programAdvanceEvaluation_unsupportedIndexIgnored() throws Exception {
16441634
Cel cel =
16451635
standardCelBuilderWithMacros()
1646-
.setOptions(
1647-
CelOptions.current()
1648-
.evaluateCanonicalTypesToNativeValues(true)
1649-
.enableUnknownTracking(true)
1650-
.build())
1636+
.setOptions(CelOptions.current().enableUnknownTracking(true).build())
16511637
.addVar("unk", MapType.create(SimpleType.STRING, SimpleType.BOOL))
16521638
.setContainer(CelContainer.ofName(""))
16531639
.addFunctionBindings()
@@ -2168,11 +2154,7 @@ public void program_fdsContainsWktDependency_descriptorInstancesMatch() throws E
21682154
Cel cel =
21692155
standardCelBuilderWithMacros()
21702156
.addMessageTypes(descriptors)
2171-
.setOptions(
2172-
CelOptions.current()
2173-
.evaluateCanonicalTypesToNativeValues(true)
2174-
.enableTimestampEpoch(true)
2175-
.build())
2157+
.setOptions(CelOptions.current().enableTimestampEpoch(true).build())
21762158
.setContainer(CelContainer.ofName("cel.expr.conformance.proto3"))
21772159
.build();
21782160
CelAbstractSyntaxTree ast =

common/src/test/java/dev/cel/common/internal/ProtoAdapterTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ public void adaptValueToProto_bidirectionalConversion() {
153153
ProtoAdapter protoAdapter =
154154
new ProtoAdapter(
155155
dynamicProto,
156-
CelOptions.current().evaluateCanonicalTypesToNativeValues(true).build());
156+
CelOptions.current().build());
157157
assertThat(protoAdapter.adaptValueToProto(value, proto.getDescriptorForType().getFullName()))
158158
.isEqualTo(proto);
159159
assertThat(protoAdapter.adaptProtoToValue(proto)).isEqualTo(value);

common/src/test/java/dev/cel/common/values/ProtoMessageValueProviderTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public void newValue_createEmptyProtoMessage() {
6666
public void newValue_createProtoMessage_fieldsPopulated() {
6767
ProtoMessageValueProvider protoMessageValueProvider =
6868
ProtoMessageValueProvider.newInstance(
69-
CelOptions.current().evaluateCanonicalTypesToNativeValues(true).build(), DYNAMIC_PROTO);
69+
CelOptions.current().build(), DYNAMIC_PROTO);
7070

7171
ProtoMessageValue protoMessageValue =
7272
(ProtoMessageValue)

conformance/src/test/java/dev/cel/conformance/ConformanceTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ public final class ConformanceTest extends Statement {
5454

5555
private static final CelOptions OPTIONS =
5656
CelOptions.current()
57-
.evaluateCanonicalTypesToNativeValues(true)
5857
.enableTimestampEpoch(true)
5958
.enableHeterogeneousNumericComparisons(true)
6059
.enableProtoDifferencerEquality(true)

extensions/src/test/java/dev/cel/extensions/CelEncoderExtensionsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
@RunWith(TestParameterInjector.class)
3838
public class CelEncoderExtensionsTest {
3939
private static final CelOptions CEL_OPTIONS =
40-
CelOptions.current().evaluateCanonicalTypesToNativeValues(true).build();
40+
CelOptions.current().build();
4141

4242
private static final CelCompiler CEL_COMPILER =
4343
CelCompilerFactory.standardCelCompilerBuilder()

extensions/src/test/java/dev/cel/extensions/CelOptionalLibraryTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ private static CelBuilder newCelBuilder(int version) {
100100
return CelFactory.standardCelBuilder()
101101
.setOptions(
102102
CelOptions.current()
103-
.evaluateCanonicalTypesToNativeValues(true)
104103
.enableTimestampEpoch(true)
105104
.build())
106105
.setStandardMacros(CelStandardMacro.STANDARD_MACROS)

optimizer/src/test/java/dev/cel/optimizer/optimizers/ConstantFoldingOptimizerTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ public class ConstantFoldingOptimizerTest {
4949
private static final CelOptions CEL_OPTIONS =
5050
CelOptions.current()
5151
.enableTimestampEpoch(true)
52-
.evaluateCanonicalTypesToNativeValues(true)
5352
.build();
5453
private static final Cel CEL =
5554
CelFactory.standardCelBuilder()

runtime/src/main/java/dev/cel/runtime/LiteRuntimeImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,6 @@ private Builder() {
204204
this.celOptions =
205205
CelOptions.current()
206206
.enableCelValue(true)
207-
.evaluateCanonicalTypesToNativeValues(true)
208207
.build();
209208
this.celValueProvider = (structType, fields) -> Optional.empty();
210209
this.customFunctionBindings = new HashMap<>();

testing/src/main/java/dev/cel/testing/BaseInterpreterTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@ public abstract class BaseInterpreterTest extends CelBaselineTestCase {
111111
.enableTimestampEpoch(true)
112112
.enableHeterogeneousNumericComparisons(true)
113113
.enableOptionalSyntax(true)
114-
.evaluateCanonicalTypesToNativeValues(true)
115114
.comprehensionMaxIterations(1_000)
116115
.build();
117116
private CelRuntime celRuntime;

0 commit comments

Comments
 (0)