chore: Fix evaluation test cases to only use pytest features

PiperOrigin-RevId: 820700378

Author: ankursharmas

tests/unittests/evaluation/test_eval_config.py

@@ -14,8 +14,6 @@
 
 from __future__ import annotations
 
-from unittest import mock
-
 from google.adk.evaluation.eval_config import _DEFAULT_EVAL_CONFIG
 from google.adk.evaluation.eval_config import EvalConfig
 from google.adk.evaluation.eval_config import get_eval_metrics_from_config
@@ -28,13 +26,14 @@ def test_get_evaluation_criteria_or_default_returns_default():
   assert get_evaluation_criteria_or_default("") == _DEFAULT_EVAL_CONFIG
 
 
-def test_get_evaluation_criteria_or_default_reads_from_file():
+def test_get_evaluation_criteria_or_default_reads_from_file(mocker):
   eval_config = EvalConfig(
       criteria={"tool_trajectory_avg_score": 0.5, "response_match_score": 0.5}
   )
-  mock_open = mock.mock_open(read_data=eval_config.model_dump_json())
-  with mock.patch("builtins.open", mock_open):
-    assert get_evaluation_criteria_or_default("dummy_path") == eval_config
+  mocker.patch(
+      "builtins.open", mocker.mock_open(read_data=eval_config.model_dump_json())
+  )
+  assert get_evaluation_criteria_or_default("dummy_path") == eval_config
 
 
 def test_get_eval_metrics_from_config():

tests/unittests/evaluation/test_evaluation_generator.py

@@ -14,8 +14,6 @@
 
 from __future__ import annotations
 
-from unittest import mock
-
 from google.adk.evaluation.app_details import AgentDetails
 from google.adk.evaluation.app_details import AppDetails
 from google.adk.evaluation.evaluation_generator import EvaluationGenerator
@@ -206,17 +204,17 @@ def test_multi_agent(
 class TestGetAppDetailsByInvocationId:
   """Test cases for EvaluationGenerator._get_app_details_by_invocation_id method."""
 
-  def test_get_app_details_by_invocation_id_empty(self):
+  def test_get_app_details_by_invocation_id_empty(self, mocker):
     """Tests with an empty list of events."""
-    mock_request_intercepter = mock.MagicMock(spec=_RequestIntercepterPlugin)
+    mock_request_intercepter = mocker.MagicMock(spec=_RequestIntercepterPlugin)
     app_details = EvaluationGenerator._get_app_details_by_invocation_id(
         [], mock_request_intercepter
     )
     assert app_details == {}
 
-  def test_get_app_details_by_invocation_id_no_model_requests(self):
+  def test_get_app_details_by_invocation_id_no_model_requests(self, mocker):
     """Tests when request_intercepter returns no model requests."""
-    mock_request_intercepter = mock.MagicMock(spec=_RequestIntercepterPlugin)
+    mock_request_intercepter = mocker.MagicMock(spec=_RequestIntercepterPlugin)
     mock_request_intercepter.get_model_request.return_value = None
     events = [
         _build_event("user", [types.Part(text="Hello")], "inv1"),
@@ -230,9 +228,9 @@ def test_get_app_details_by_invocation_id_no_model_requests(self):
         events[1]
     )
 
-  def test_get_app_details_single_invocation_single_agent(self):
+  def test_get_app_details_single_invocation_single_agent(self, mocker):
     """Tests a single invocation with one agent."""
-    mock_request_intercepter = mock.MagicMock(spec=_RequestIntercepterPlugin)
+    mock_request_intercepter = mocker.MagicMock(spec=_RequestIntercepterPlugin)
     mock_llm_request = LlmRequest(model="test")
     mock_llm_request.config.system_instruction = "instruction1"
     mock_llm_request.config.tools = [types.Tool()]
@@ -262,9 +260,9 @@ def test_get_app_details_single_invocation_single_agent(self):
         events[1]
     )
 
-  def test_get_app_details_multiple_invocations_multiple_agents(self):
+  def test_get_app_details_multiple_invocations_multiple_agents(self, mocker):
     """Tests multiple invocations with multiple agents."""
-    mock_request_intercepter = mock.MagicMock(spec=_RequestIntercepterPlugin)
+    mock_request_intercepter = mocker.MagicMock(spec=_RequestIntercepterPlugin)
 
     def get_model_request_side_effect(event):
       mock_llm_request = LlmRequest(model="test")