You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- Browse issues labeled **`good first issue`** (newcomer-friendly) or **`help wanted`** (general contributions).
47
+
- Browse issues labeled **`good first issue`** (newcomer-friendly) or **`help wanted`** (general contributions).
48
48
- For other issues, please kindly ask before contributing to avoid duplication.
49
49
50
50
51
51
### Requirement for PRs
52
52
53
-
- All PRs, other than small documentation or typo fixes, should have a Issue assoicated. If not, please create one.
53
+
- All PRs, other than small documentation or typo fixes, should have a Issue assoicated. If not, please create one.
54
54
- Small, focused PRs. Keep changes minimal—one concern per PR.
55
55
- For bug fixes or features, please provide logs or screenshot after the fix is applied to help reviewers better understand the fix.
56
56
- Please include a `testing plan` section in your PR to talk about how you will test. This will save time for PR review. See `Testing Requirements` section for more details.
@@ -72,12 +72,12 @@ Please add or update unit tests for your change. Please include a summary of pas
72
72
73
73
Requirements for unit tests:
74
74
75
-
-**Coverage:** Cover new features, edge cases, error conditions, and typical use cases.
76
-
-**Location:** Add or update tests under `tests/unittests/`, following existing naming conventions (e.g., `test_<module>_<feature>.py`).
77
-
-**Framework:** Use `pytest`. Tests should be:
78
-
- Fast and isolated.
79
-
- Written clearly with descriptive names.
80
-
- Free of external dependencies (use mocks or fixtures as needed).
75
+
-**Coverage:** Cover new features, edge cases, error conditions, and typical use cases.
76
+
-**Location:** Add or update tests under `tests/unittests/`, following existing naming conventions (e.g., `test_<module>_<feature>.py`).
77
+
-**Framework:** Use `pytest`. Tests should be:
78
+
- Fast and isolated.
79
+
- Written clearly with descriptive names.
80
+
- Free of external dependencies (use mocks or fixtures as needed).
81
81
-**Quality:** Aim for high readability and maintainability; include docstrings or comments for complex scenarios.
82
82
83
83
#### Manual End-to-End (E2E) Tests
@@ -86,15 +86,15 @@ Manual E2E tests ensure integrated flows work as intended. Your tests should cov
86
86
87
87
Depending on your change:
88
88
89
-
-**ADK Web:**
90
-
- Use the `adk web` to verify functionality.
91
-
- Capture and attach relevant screenshots demonstrating the UI/UX changes or outputs.
89
+
-**ADK Web:**
90
+
- Use the `adk web` to verify functionality.
91
+
- Capture and attach relevant screenshots demonstrating the UI/UX changes or outputs.
92
92
- Label screenshots clearly in your PR description.
93
93
94
94
-**Runner:**
95
95
- Provide the testing setup. For example, the agent definition, and the runner setup.
96
-
- Execute the `runner` tool to reproduce workflows.
97
-
- Include the command used and console output showing test results.
96
+
- Execute the `runner` tool to reproduce workflows.
97
+
- Include the command used and console output showing test results.
98
98
- Highlight sections of the log that directly relate to your change.
99
99
100
100
### Documentation
@@ -117,19 +117,16 @@ For any changes that impact user-facing documentation (guides, API reference, tu
0 commit comments