Fix Bitbucket server version comparison

Fixes #2

Author: goober

build.gradle

@@ -25,6 +25,9 @@ dependencies {
 
     compileOnly 'org.projectlombok:lombok:1.18.8'
     annotationProcessor 'org.projectlombok:lombok:1.18.8'
+
+    testImplementation 'org.junit.jupiter:junit-jupiter-api:5.5.2'
+    testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.5.2'
 }
 
 assemble.dependsOn(

src/main/java/com/github/goober/sonarqube/plugin/decorator/bitbucket/model/ServerProperties.java

@@ -3,24 +3,33 @@
 import lombok.AllArgsConstructor;
 import lombok.Value;
 
-import static java.lang.String.format;
-
 @Value
 @AllArgsConstructor
 public class ServerProperties {
-    private static final int CODE_INSIGHT_MAJOR_VERSION = 5;
-    private static final int CODE_INSIGHT_MINOR_VERSION = 15;
-
-    public static String CODE_INSIGHT_VERSION = format("%d.%d",
-            CODE_INSIGHT_MAJOR_VERSION,
-            CODE_INSIGHT_MINOR_VERSION);
+    public static final String CODE_INSIGHT_VERSION = "5.15";
 
     String version;
 
     public boolean hasCodeInsightsApi() {
-        String[] semver = semver(version);
-        return Integer.parseInt(semver[0]) >= CODE_INSIGHT_MAJOR_VERSION &&
-                Integer.parseInt(semver[1]) >= CODE_INSIGHT_MINOR_VERSION;
+        return compareTo(CODE_INSIGHT_VERSION) >= 0;
+    }
+
+    private int compareTo(String other) {
+        String[] current = semver(version);
+        String[] minimum = semver(other);
+
+        int length = Math.max(current.length, minimum.length);
+        for(int i = 0; i < length; i++) {
+            int thisPart = i < current.length ?
+                    Integer.parseInt(current[i]) : 0;
+            int thatPart = i < minimum.length ?
+                    Integer.parseInt(minimum[i]) : 0;
+            if(thisPart < thatPart)
+                return -1;
+            if(thisPart > thatPart)
+                return 1;
+        }
+        return 0;
     }
 
     private String[] semver(String v) {

src/test/java/com/github/goober/sonarqube/plugin/decorator/bitbucket/model/ServerPropertiesTest.java

@@ -0,0 +1,27 @@
+package com.github.goober.sonarqube.plugin.decorator.bitbucket.model;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+public class ServerPropertiesTest {
+
+    @Test
+    public void server_with_version_without_code_insights_returns_false() {
+       ServerProperties underTest = new ServerProperties("2.1");
+       assertFalse(underTest.hasCodeInsightsApi());
+    }
+
+    @Test
+    public void server_version_greater_than_minimum_for_code_insights_returns_true() {
+        ServerProperties underTest = new ServerProperties("6.7.1");
+        assertTrue(underTest.hasCodeInsightsApi());
+    }
+
+    @Test
+    public void server_version_equals_to_minimum_for_code_insights_return_true() {
+        ServerProperties underTest = new ServerProperties(ServerProperties.CODE_INSIGHT_VERSION);
+        assertTrue(underTest.hasCodeInsightsApi());
+    }
+}