Enable linters for golangci-lint (#1221)

* Enable linters for golangci-lint

* Remove unused nolint

* Fix lint

Author: sonatard

.golangci.yml

@@ -73,6 +73,7 @@ linters:
     - dogsled
     - dupl
     - errcheck
+    - exhaustive
     - funlen
     - gochecknoinits
     - goconst
@@ -91,6 +92,7 @@ linters:
     - lll
     - misspell
     - nakedret
+    - noctx
     - nolintlint
     - rowserrcheck
     - scopelint
@@ -106,15 +108,13 @@ linters:
 
   # don't enable:
   # - asciicheck
-  # - exhaustive (TODO: enable after next release; current release at time of writing is v1.27)
   # - gochecknoglobals
   # - gocognit
   # - godot
   # - godox
   # - goerr113
   # - maligned
   # - nestif
-  # - noctx (TODO: enable after next release; current release at time of writing is v1.27)
   # - prealloc
   # - testpackage
   # - wsl

pkg/commands/run.go

@@ -446,8 +446,8 @@ func (e *Executor) executeRun(_ *cobra.Command, args []string) {
 
 // to be removed when deadline is finally decommissioned
 func (e *Executor) setTimeoutToDeadlineIfOnlyDeadlineIsSet() {
-	//lint:ignore SA1019 We want to promoted the deprecated config value when needed
-	deadlineValue := e.cfg.Run.Deadline // nolint:staticcheck
+	// nolint:staticcheck
+	deadlineValue := e.cfg.Run.Deadline
 	if deadlineValue != 0 && e.cfg.Run.Timeout == defaultTimeout {
 		e.cfg.Run.Timeout = deadlineValue
 	}