Skip to content

Commit b31cfd6

Browse files
jirfagjirfag
committed
update go-critic
$ git cherry --abbrev -v 0af0999fabfb ee9bf5809ead + abd8436 all: enable Go modules on CI (#753) + 3c9d0fb checkers: recognize //line and //nolint in commentFormatting (#756) + 0b517d7 checkers: extend deprecatedComment patterns (#757) + 09100f6 checkers: use astcast package instead of coerce.go (#758) + 2e9e97f checker: simplify boolExprSimplify (#759) + 575701e make: add go-consistent to CI checks list (#761) + b55f431 checkers: fix unlambda handling of builtins (#763) + 5a7dee3 checker: handle lambdas properly in boolExprSimplify (#765) + 5ce3939 checkers: teach boolExprSimplify a few new tricks (#766) + 04d160f checkers: add new patterns to boolExprSimplify (#768) + 09582e2 make: collect coverprofile separately from goveralls (#769) + d8d0ee4 checkers: recognize NOTE pattern in deprecatedComment (#770) + 12f0f85 Update copyright notice to 2019 (#771) + f54bdb6 checkers: add stringXbytes checker + 170d65c checkers: followup for #773 (#774) + 84e9e83 checkers: make stringXbytes more linear (#775) + a800815 checkers: add Depreacted typo pattern (#776) + 6751be9 checkers: add hexLiterals (#772) + ac61906 checkers: add typeAssertChain checker (#782) + d19dbf1 checkers: add codegenComment checker (#783) + d82b576 checkers: proper pkg/obj check for flagName (#786) + dfcf754 ci: enable integration tests (#787) + 5dafc45 checkers: fix equalFold false positive (#788) + ed5e8e7 checkers: refactor and fix hexLiteral checker (#789) + e704e07 checkers: add argOrder checker (#790) + 34c1dc8 checkers: add Split handling to argOrder checker (#791) + cbe095d checkers: add math.Max and math.Min to dupArg (#792) + c986ee5 checkers: add checkers info fields test (#794) + 66e5832 cmd/makedocs: use lintpack, fix build (#793) + 6bce9d0 cmd/makedocs: add enabled/disabled by default info (#795) + 4adbf9a checkers: simplify flagName (#799) + 07de34a checkers: add octalLiteral checker (#798) + 765907a cmd/makedocs: add checker param docs (#796) + ee9bf58 cmd/makedocs: fix headers formatting (#803)
1 parent b3bad28 commit b31cfd6

26 files changed

+1492
-213
lines changed

‎.golangci.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ linters-settings:
3131
- experimental
3232
disabled-checks:
3333
- wrapperFunc
34-
- commentFormatting # https://github.com/go-critic/go-critic/issues/755
3534

3635
linters:
3736
enable-all: true

‎README.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -779,7 +779,6 @@ linters-settings:
779779
- experimental
780780
disabled-checks:
781781
- wrapperFunc
782-
- commentFormatting # https://github.com/go-critic/go-critic/issues/755
783782
784783
linters:
785784
enable-all: true

‎go.mod‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ require (
66
github.com/StackExchange/wmi v0.0.0-20180116203802-5d049714c4a6 // indirect
77
github.com/davecgh/go-spew v1.1.0 // indirect
88
github.com/fatih/color v1.6.0
9-
github.com/go-critic/go-critic v0.0.0-20181204210945-0af0999fabfb
9+
github.com/go-critic/go-critic v0.0.0-20181204210945-ee9bf5809ead
1010
github.com/go-lintpack/lintpack v0.5.2
1111
github.com/go-ole/go-ole v1.2.1 // indirect
1212
github.com/gobwas/glob v0.2.3 // indirect

‎go.sum‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ github.com/fatih/color v1.6.0 h1:66qjqZk8kalYAvDRtM1AdAJQI0tj4Wrue3Eq3B3pmFU=
1010
github.com/fatih/color v1.6.0/go.mod h1:Zm6kSWBoL9eyXnKyktHP6abPY2pDugNf5KwzbycvMj4=
1111
github.com/fsnotify/fsnotify v1.4.7 h1:IXs+QLmnXW2CcXuY+8Mzv/fWEsPGWxqefPtCP5CnV9I=
1212
github.com/fsnotify/fsnotify v1.4.7/go.mod h1:jwhsz4b93w/PPRr/qN1Yymfu8t87LnFCMoQvtojpjFo=
13-
github.com/go-critic/go-critic v0.0.0-20181204210945-0af0999fabfb h1:faOtDYqSVJsFEJAW+SwEMvh7alhYsb42fER6tt8yXfA=
14-
github.com/go-critic/go-critic v0.0.0-20181204210945-0af0999fabfb/go.mod h1:PSww+HOJZQ3TN2hi6sphNiW1PhwELxbsK8+Jy1sjML8=
13+
github.com/go-critic/go-critic v0.0.0-20181204210945-ee9bf5809ead h1:qwmAYufKDopQnFdeMw+iHJVxAd2CbF+VFKHyJJwnPKk=
14+
github.com/go-critic/go-critic v0.0.0-20181204210945-ee9bf5809ead/go.mod h1:3MzXZKJdeXqdU9cj+rvZdNiN7SZ8V9OjybF8loZDmHU=
1515
github.com/go-lintpack/lintpack v0.5.2 h1:DI5mA3+eKdWeJ40nU4d6Wc26qmdG8RCi/btYq0TuRN0=
1616
github.com/go-lintpack/lintpack v0.5.2/go.mod h1:NwZuYi2nUHho8XEIZ6SIxihrnPoqBTDqfpXvXAN0sXM=
1717
github.com/go-ole/go-ole v1.2.1 h1:2lOsA72HgjxAuMlKpFiCbHTvu44PIVkZ5hqm3RSdI/E=
@@ -96,6 +96,7 @@ github.com/mattn/go-colorable v0.0.9 h1:UVL0vNpWh04HeJXV0KLcaT7r06gOH2l4OW6ddYRU
9696
github.com/mattn/go-colorable v0.0.9/go.mod h1:9vuHe8Xs5qXnSaW/c/ABM9alt+Vo+STaOChaDxuIBZU=
9797
github.com/mattn/go-isatty v0.0.3 h1:ns/ykhmWi7G9O+8a448SecJU3nSMBXJfqQkl0upE1jI=
9898
github.com/mattn/go-isatty v0.0.3/go.mod h1:M+lRXTBqGeGNdLjl/ufCoiOlB5xdOkqRJdNxMWT7Zi4=
99+
github.com/mattn/goveralls v0.0.2/go.mod h1:8d1ZMHsd7fW6IRPKQh46F2WRpyib5/X4FOpevwGNQEw=
99100
github.com/mitchellh/go-homedir v1.0.0 h1:vKb8ShqSby24Yrqr/yDYkuFz8d0WUjys40rvnGC8aR0=
100101
github.com/mitchellh/go-homedir v1.0.0/go.mod h1:SfyaCUpYCn1Vlf4IUYiD9fPX4A5wJrkLzIz1N1q0pr0=
101102
github.com/mitchellh/go-ps v0.0.0-20170309133038-4fdf99ab2936 h1:kw1v0NlnN+GZcU8Ma8CLF2Zzgjfx95gs3/GN3vYAPpo=

‎vendor/github.com/go-critic/go-critic/LICENSE‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎vendor/github.com/go-critic/go-critic/checkers/appendCombine_checker.go‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎vendor/github.com/go-critic/go-critic/checkers/argOrder_checker.go‎

Lines changed: 98 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)