don't make typecheck issues without file/line info

Author: jirfag

pkg/commands/run.go

@@ -395,7 +395,7 @@ func (e *Executor) setupExitCode(ctx context.Context) {
 	}
 
 	if e.exitCode == exitcodes.Success &&
-		os.Getenv("GL_TEST_RUN") == "1" &&
+		(os.Getenv("GL_TEST_RUN") == "1" || os.Getenv("FAIL_ON_WARNINGS") == "1") &&
 		len(e.reportData.Warnings) != 0 {
 
 		e.exitCode = exitcodes.WarningInTest

pkg/golinters/typecheck.go

@@ -63,11 +63,8 @@ func (lint TypeCheck) Run(ctx context.Context, lintCtx *linter.Context) ([]resul
 		errors := libpackages.ExtractErrors(pkg)
 		for _, err := range errors {
 			i, perr := lint.parseError(err)
-			if perr != nil {
-				res = append(res, result.Issue{
-					Text:       err.Msg,
-					FromLinter: lint.Name(),
-				})
+			if perr != nil { // failed to parse
+				lintCtx.Log.Errorf("typechecking error: %s", err.Msg)
 			} else {
 				res = append(res, *i)
 			}