Fix unparam crash on nil constant

Author: jirfag

Gopkg.lock

@@ -26,7 +26,7 @@
 
 [[constraint]]
   name = "mvdan.cc/unparam"
-  branch = "master"
+  branch = "fix-crash-on-nil-constant"
   source = "github.com/golangci/unparam"
 
 [[constraint]]

Gopkg.toml

@@ -22,8 +22,8 @@ func (lint Unparam) Run(ctx context.Context, lintCtx *linter.Context) ([]result.
 	us := &lintCtx.Settings().Unparam
 
 	c := &check.Checker{}
-	c.Algo(us.Algo)
-	c.Exported(us.CheckExported)
+	c.CallgraphAlgorithm(us.Algo)
+	c.CheckExportedFuncs(us.CheckExported)
 	c.Program(lintCtx.Program)
 	c.ProgramSSA(lintCtx.SSAProgram)
 

pkg/golinters/unparam.go

@@ -133,13 +133,13 @@ func (c *Checker) ProgramSSA(prog *ssa.Program) {
 	c.prog = prog
 }
 
-// Algo supplies Checker with the call graph construction algorithm.
-func (c *Checker) Algo(algo string) {
+// CallgraphAlgorithm supplies Checker with the call graph construction algorithm.
+func (c *Checker) CallgraphAlgorithm(algo string) {
 	c.algo = algo
 }
 
-// Algo supplies Checker with the exported setting.
-func (c *Checker) Exported(exported bool) {
+// CheckExportedFuncs sets whether to inspect exported functions
+func (c *Checker) CheckExportedFuncs(exported bool) {
 	c.exported = exported
 }
 
@@ -255,6 +255,16 @@ func (c *Checker) addIssue(fn *ssa.Function, pos token.Pos, format string, args
 	})
 }
 
+// constantValueToString returns string representation for constant value
+func constantValueToString(val constant.Value) string {
+	valStr := "nil" // an untyped nil is a nil constant.Value
+	if val != nil {
+		valStr = val.String()
+	}
+
+	return valStr
+}
+
 // checkFunc checks a single function for unused parameters.
 func (c *Checker) checkFunc(fn *ssa.Function, pkgInfo *loader.PackageInfo) {
 	c.debug("func %s\n", fn.RelString(fn.Package().Pkg))
@@ -310,10 +320,7 @@ func (c *Checker) checkFunc(fn *ssa.Function, pkgInfo *loader.PackageInfo) {
 			// just one non-nil return (too many false positives)
 			continue
 		}
-		valStr := "nil" // an untyped nil is a nil constant.Value
-		if val != nil {
-			valStr = val.String()
-		}
+		valStr := constantValueToString(val)
 		if calledInReturn(inboundCalls) {
 			continue
 		}
@@ -497,10 +504,11 @@ func (c *Checker) alwaysReceivedConst(in []*callgraph.Edge, par *ssa.Parameter,
 			seenOrig = ""
 		}
 	}
-	if seenOrig != "" && seenOrig != seen.String() {
+	seenStr := constantValueToString(seen)
+	if seenOrig != "" && seenOrig != seenStr {
 		return fmt.Sprintf("%s (%v)", seenOrig, seen)
 	}
-	return seen.String()
+	return seenStr
 }
 
 // anyRealUse reports whether a parameter has any relevant use within its