Commit 726029b
build: surface error when noticing test failure
'set -e' means exit immediately on error.
Previously, the presubmit from integration test may experience
false positive because the exit code from npm test is not being
captured.
This false positive is noticed in CL 649258 where kokoro test
failed but LUCI test passed.
This CL should fail due to go1.24 vet behavior change but should
pass if rebased CL 649475.
For #3533
Change-Id: Iee7d5d02c178b8655a81b088f914d65237f79834
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/649635
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>1 parent 20da28f commit 726029b
1 file changed
+3
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
52 | 54 | | |
53 | 55 | | |
54 | 56 | | |
| |||
0 commit comments