File tree Expand file tree Collapse file tree 1 file changed +8
-0
lines changed Expand file tree Collapse file tree 1 file changed +8
-0
lines changed Original file line number Diff line number Diff line change @@ -15,6 +15,14 @@ import (
1515// file.
1616// If the same package is imported multiple times, the last appearance is
1717// recorded.
18+ //
19+ // TODO(adonovan): this function ignores the effect of shadowing. It
20+ // should accept a [token.Pos] and a [types.Info] and compute only the
21+ // set of imports that are not shadowed at that point, analogous to
22+ // [analysisinternal.AddImport]. It could also compute (as a side
23+ // effect) the set of additional imports required to ensure that there
24+ // is an accessible import for each necessary package, making it
25+ // converge even more closely with AddImport.
1826func FileQualifier (f * ast.File , pkg * types.Package ) types.Qualifier {
1927 // Construct mapping of import paths to their defined names.
2028 // It is only necessary to look at renaming imports.
You can’t perform that action at this time.
0 commit comments