google: Make sure time is always in UTC

Ryan Kohler · codyoss · commit 5366d9dc1934 · 2021-03-11T16:31:35.000Z
If times are stored in different time zones, then we occasionally get heisenbugs about expired tokens Change-Id: I0c117977688d8d6c7b12b211092e5040a41a1f46 GitHub-Last-Rev: 3ff51b3 GitHub-Pull-Request: #482 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/300929 Reviewed-by: Tyler Bui-Palsulich <tbp@google.com> Trust: Tyler Bui-Palsulich <tbp@google.com> Trust: Cody Oss <codyoss@google.com> Run-TryBot: Tyler Bui-Palsulich <tbp@google.com> TryBot-Result: Go Bot <gobot@golang.org>
diff --git a/google/internal/externalaccount/basecredentials.go b/google/internal/externalaccount/basecredentials.go
@@ -14,7 +14,9 @@ import (
 )
 
 // now aliases time.Now for testing
-var now = time.Now
+var now = func() time.Time {
+	return time.Now().UTC()
+}
 
 // Config stores the configuration for fetching tokens with external credentials.
 type Config struct {

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,9 @@ import (`
`14`	`14`	`)`
`15`	`15`
`16`	`16`	`// now aliases time.Now for testing`
`17`		`-var now = time.Now`
	`17`	`+var now = func() time.Time {`
	`18`	`+ return time.Now().UTC()`
	`19`	`+}`
`18`	`20`
`19`	`21`	`// Config stores the configuration for fetching tokens with external credentials.`
`20`	`22`	`type Config struct {`