Skip to content

Commit 29d5ad4

Browse files
changkunhyangah
authored andcommitted
cmd/gomobile: remove outdated TODO of bundle ID
The TODO message was introduced in CL 13041, but later resolved in CL 77070 because it allows bundle id customization. Remove the oudated TODO message. Change-Id: Ib32793ace937f67b5c95d6efadd6d4eef48a8986 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/369200 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Trust: Alex Rakoczy <alex@golang.org> Run-TryBot: Alex Rakoczy <alex@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org>
1 parent 1ab9019 commit 29d5ad4

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

cmd/gomobile/build_apple.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ func goAppleBuild(pkg *packages.Package, bundleID string, targets []targetInfo)
3333

3434
infoplist := new(bytes.Buffer)
3535
if err := infoplistTmpl.Execute(infoplist, infoplistTmplData{
36-
// TODO: better bundle id.
3736
BundleID: bundleID + "." + productName,
3837
Name: strings.Title(path.Base(pkg.PkgPath)),
3938
}); err != nil {

0 commit comments

Comments
 (0)