Skip to content

Commit 85bec79

Browse files
committed
cmd/go/testdata/script: loosen list_empty_importpath for freebsd
We've been seeing the flakes where we get a 'no errors' output on freebsd in addition to windows and solaris. Also allow that case to avoid flakes. For #73976 Change-Id: I6a6a696445ec908b55520d8d75e7c1f867b9c092 Reviewed-on: https://go-review.googlesource.com/c/go/+/715640 Reviewed-by: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Matloob <matloob@google.com> Reviewed-by: Ian Alexander <jitsu@google.com>
1 parent 17b5707 commit 85bec79

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

src/cmd/go/testdata/script/list_empty_importpath.txt

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
! go list all
22
! stderr 'panic'
3-
[!GOOS:windows] [!GOOS:solaris] stderr 'invalid import path'
4-
# #73976: Allow 'no errors' on Windows and Solaris until issue
3+
[!GOOS:windows] [!GOOS:solaris] [!GOOS:freebsd] [!GOOS:openbsd] [!GOOS:netbsd] stderr 'invalid import path'
4+
# #73976: Allow 'no errors' on Windows, Solaris, and BSD until issue
55
# is resolved to prevent flakes. 'no errors' is printed by
66
# empty scanner.ErrorList errors so that's probably where the
77
# message is coming from, though we don't know how.
88
[GOOS:windows] stderr 'invalid import path|no errors'
99
[GOOS:solaris] stderr 'invalid import path|no errors'
10+
[GOOS:freebsd] stderr 'invalid import path|no errors'
11+
[GOOS:openbsd] stderr 'invalid import path|no errors'
12+
[GOOS:netbsd] stderr 'invalid import path|no errors'
1013

1114
# go list produces a package for 'p' but not for ''
1215
go list -e all

0 commit comments

Comments
 (0)