Skip to content

Commit 643f80a

Browse files
committed
runtime: add ppc and s390 to 32 build constraints for gccgo
Theses are not supported by the go compiler but it may helps porting to gccgo. I have no idea if this change is correct, but it is weird that os_linux32.go and os_linux64.go should have ppc & s390 but not all other files gated to 32bits in the same package. Change-Id: I0bb70cdb88c19096386320d02d546942263e009d Reviewed-on: https://go-review.googlesource.com/c/go/+/714082 Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Jorropo <jorropo.pgm@gmail.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
1 parent 0afbeb5 commit 643f80a

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

src/runtime/hash32.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// Hashing algorithm inspired by
66
// wyhash: https://github.com/wangyi-fudan/wyhash/blob/ceb019b530e2c1c14d70b79bfa2bc49de7d95bc1/Modern%20Non-Cryptographic%20Hash%20Function%20and%20Pseudorandom%20Number%20Generator.pdf
77

8-
//go:build 386 || arm || mips || mipsle || wasm
8+
//go:build 386 || arm || mips || mipsle || wasm || (gccgo && (ppc || s390))
99

1010
package runtime
1111

src/runtime/mpagealloc_32bit.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// Use of this source code is governed by a BSD-style
33
// license that can be found in the LICENSE file.
44

5-
//go:build 386 || arm || mips || mipsle || wasm
5+
//go:build 386 || arm || mips || mipsle || wasm || (gccgo && (ppc || s390))
66

77
// wasm is a treated as a 32-bit architecture for the purposes of the page
88
// allocator, even though it has 64-bit pointers. This is because any wasm

src/runtime/panic32.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// Use of this source code is governed by a BSD-style
33
// license that can be found in the LICENSE file.
44

5-
//go:build 386 || arm || mips || mipsle
5+
//go:build 386 || arm || mips || mipsle || (gccgo && (ppc || s390))
66

77
package runtime
88

src/runtime/tagptr_32bit.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// Use of this source code is governed by a BSD-style
33
// license that can be found in the LICENSE file.
44

5-
//go:build 386 || arm || mips || mipsle
5+
//go:build 386 || arm || mips || mipsle || (gccgo && (ppc || s390))
66

77
package runtime
88

0 commit comments

Comments
 (0)