internal/itoa, internal/runtime/strconv: delete

Replaced by internal/strconv.

Change-Id: I0656a9ad5075e60339e963fbae7d194d2f3e16be
Reviewed-on: https://go-review.googlesource.com/c/go/+/716001
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

Author: rsc

src/cmd/internal/objabi/pkgspecial.go

@@ -55,7 +55,6 @@ var runtimePkgs = []string{
 	"internal/runtime/gc/scan",
 	"internal/runtime/maps",
 	"internal/runtime/math",
-	"internal/runtime/strconv",
 	"internal/runtime/sys",
 	"internal/runtime/syscall/linux",
 	"internal/runtime/syscall/windows",
@@ -71,6 +70,7 @@ var runtimePkgs = []string{
 	"internal/goexperiment",
 	"internal/goos",
 	"internal/profilerecord",
+	"internal/strconv",
 	"internal/stringslite",
 }
 

src/go/build/deps_test.go

@@ -87,7 +87,6 @@ var depsRules = `
 	structs
 	< internal/bytealg
 	< internal/stringslite
-	< internal/itoa
 	< internal/unsafeheader
 	< internal/race
 	< internal/msan
@@ -100,7 +99,6 @@ var depsRules = `
 	< internal/runtime/gc
 	< internal/runtime/math
 	< internal/runtime/maps
-	< internal/runtime/strconv
 	< internal/runtime/cgroup
 	< internal/runtime/gc/scan
 	< runtime
@@ -301,7 +299,7 @@ var depsRules = `
 	FMT
 	< text/template/parse;
 
-	internal/bytealg, internal/itoa, math/bits, slices, strconv, unique
+	internal/bytealg, math/bits, slices, strconv, unique
 	< net/netip;
 
 	FMT, net/netip

src/internal/coverage/pkid.go

@@ -63,12 +63,12 @@ var rtPkgs = [...]string{
 	"internal/runtime/exithook",
 	"internal/runtime/gc",
 	"internal/runtime/math",
-	"internal/runtime/strconv",
 	"internal/runtime/sys",
 	"internal/runtime/maps",
 	"internal/runtime/syscall/linux",
 	"internal/runtime/syscall/windows",
 	"internal/runtime/cgroup",
+	"internal/strconv",
 	"internal/stringslite",
 	"runtime",
 }

src/internal/itoa/itoa.go

@@ -5,7 +5,7 @@
 package poll
 
 import (
-	"internal/itoa"
+	"internal/strconv"
 	"runtime"
 	"sync"
 	"syscall"
@@ -72,7 +72,7 @@ func (aio *asyncIO) Cancel() {
 	if aio.pid == -1 {
 		return
 	}
-	f, e := syscall.Open("/proc/"+itoa.Itoa(aio.pid)+"/note", syscall.O_WRONLY)
+	f, e := syscall.Open("/proc/"+strconv.Itoa(aio.pid)+"/note", syscall.O_WRONLY)
 	if e != nil {
 		return
 	}

src/internal/itoa/itoa_test.go

@@ -7,7 +7,7 @@
 package poll
 
 import (
-	"internal/itoa"
+	"internal/strconv"
 	"internal/syscall/unix"
 	"io"
 	"sync/atomic"
@@ -379,7 +379,7 @@ func (fd *FD) Write(p []byte) (int, error) {
 				// If we don't check this we will panic
 				// with slice bounds out of range.
 				// Use a more informative panic.
-				panic("invalid return from write: got " + itoa.Itoa(n) + " from a write of " + itoa.Itoa(max-nn))
+				panic("invalid return from write: got " + strconv.Itoa(n) + " from a write of " + strconv.Itoa(max-nn))
 			}
 			nn += n
 		}

src/internal/poll/fd_io_plan9.go

@@ -6,8 +6,8 @@ package cgroup
 
 import (
 	"internal/bytealg"
-	"internal/runtime/strconv"
 	"internal/runtime/syscall/linux"
+	"internal/strconv"
 )
 
 var (
@@ -220,8 +220,8 @@ func parseV1Number(buf []byte) (int64, error) {
 	}
 	buf = buf[:i]
 
-	val, ok := strconv.Atoi64(string(buf))
-	if !ok {
+	val, err := strconv.ParseInt(string(buf), 10, 64)
+	if err != nil {
 		return 0, errMalformedFile
 	}
 
@@ -280,13 +280,13 @@ func parseV2Limit(buf []byte) (float64, bool, error) {
 	}
 	periodStr = periodStr[:i]
 
-	quota, ok := strconv.Atoi64(string(quotaStr))
-	if !ok {
+	quota, err := strconv.ParseInt(string(quotaStr), 10, 64)
+	if err != nil {
 		return 0, false, errMalformedFile
 	}
 
-	period, ok := strconv.Atoi64(string(periodStr))
-	if !ok {
+	period, err := strconv.ParseInt(string(periodStr), 10, 64)
+	if err != nil {
 		return 0, false, errMalformedFile
 	}