Skip to content

Commit 32f8d64

Browse files
nsrip-ddgopherbot
authored andcommitted
runtime: document that tracefpunwindoff applies to some profilers
The tracefpunwindoff GODEBUG applies to all the places where we use frame pointer unwinding. Originally that was just the execution tracer, but now we also use it for the block and mutex profilers. Change-Id: I6a6a69641fede668d96335582dba6d43e62f6a51 Reviewed-on: https://go-review.googlesource.com/c/go/+/718522 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> Auto-Submit: Nick Ripley <nick.ripley@datadoghq.com> Reviewed-by: Michael Pratt <mpratt@google.com>
1 parent 1c1c194 commit 32f8d64

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/runtime/extern.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -211,10 +211,11 @@ It is a comma-separated list of name=val pairs setting these named variables:
211211
report. This also extends the information returned by runtime.Stack.
212212
Setting N to 0 will report no ancestry information.
213213
214-
tracefpunwindoff: setting tracefpunwindoff=1 forces the execution tracer to
215-
use the runtime's default stack unwinder instead of frame pointer unwinding.
216-
This increases tracer overhead, but could be helpful as a workaround or for
217-
debugging unexpected regressions caused by frame pointer unwinding.
214+
tracefpunwindoff: setting tracefpunwindoff=1 forces the execution tracer
215+
and block and mutex profilers to use the runtime's default stack
216+
unwinder instead of frame pointer unwinding. This increases their
217+
overhead, but could be helpful as a workaround or for debugging
218+
unexpected regressions caused by frame pointer unwinding.
218219
219220
traceadvanceperiod: the approximate period in nanoseconds between trace generations. Only
220221
applies if a program is built with GOEXPERIMENT=exectracer2. Used primarily for testing

0 commit comments

Comments
 (0)