Created issues for TODO comments

Author: chitoyuu

gdnative-core/src/core_types/geom/plane.rs

@@ -1,6 +1,6 @@
 use crate::core_types::{IsEqualApprox, Vector3};
 
-// TODO enforce invariants via setters, make fields private
+// TODO(#994) enforce invariants via setters, make fields private
 // Otherwise almost all methods need to panic
 // - normal.length() == 1
 // - d > 0
@@ -322,7 +322,7 @@ mod test {
         assert!(!p.contains_point(Vector3::new(6.562291, -0.186564, -0.101982)));
     }
 
-    // TODO contains_point_eps()
+    // TODO(#994) contains_point_eps()
 
     #[test]
     fn intersect_3() {

gdnative-core/src/core_types/string.rs

@@ -286,8 +286,6 @@ impl GodotString {
         sys_string.leak();
         this
     }
-
-    // TODO: many missing methods.
 }
 
 impl Clone for GodotString {
@@ -454,7 +452,7 @@ impl Index<usize> for GodotString {
     }
 }
 
-// TODO: Is it useful to expose this type?
+// TODO(#993): Is it useful to expose this type?
 // Could just make it an internal detail of how to convert to a rust string.
 #[doc(hidden)]
 pub struct Utf8String(pub(crate) sys::godot_char_string);

gdnative-core/src/core_types/variant_array.rs

@@ -181,21 +181,6 @@ impl<Own: Ownership> VariantArray<Own> {
         self.into_iter()
     }
 
-    // TODO
-    // pub fn sort_custom(&mut self, obj: ?, s: ?) {
-    //     unimplemented!()
-    // }
-
-    // pub fn bsearch(&mut self, val: (), before: bool) -> i32 {
-    //     unsafe {
-    //         (get_api().godot_array_bsearch)(self.sys_mut(), val, before)
-    //     }
-    // }
-
-    // pub fn bsearch_custom(&mut self, val: ?, obj: ?, s: ?, before: bool) -> i32 {
-    //     unimplemented!();
-    // }
-
     #[doc(hidden)]
     #[inline]
     pub fn sys(&self) -> *const sys::godot_array {

gdnative-core/src/export/class_builder.rs

@@ -7,7 +7,7 @@ use crate::export::*;
 use crate::object::NewRef;
 use crate::private::get_api;
 
-// TODO unify string parameters across all buiders
+// TODO(#996): unify string parameters across all buiders
 // Potential candidates:
 // * &str
 // * impl Into<GodotString>

gdnative-core/src/export/property.rs

@@ -114,7 +114,7 @@ where
         let default = self.default.to_variant();
 
         let mut attr = sys::godot_property_attributes {
-            rset_type: sys::godot_method_rpc_mode_GODOT_METHOD_RPC_MODE_DISABLED, // TODO:
+            rset_type: sys::godot_method_rpc_mode_GODOT_METHOD_RPC_MODE_DISABLED, // TODO(#995)
             type_: variant_type as sys::godot_int,
             hint: hint_kind,
             hint_string: hint_string.to_sys(),

gdnative-core/src/object/mod.rs

@@ -1000,7 +1000,7 @@ pub struct Null<T>(PhantomData<T>);
 
 impl<T: GodotObject> Null<T> {
     /// Creates an explicit null reference that can be used as a method argument.
-    // TODO consider something more idiomatic, like module::null::<T>(), similar to std::ptr::null()
+    // TODO(#997) consider something more idiomatic, like module::null::<T>(), similar to std::ptr::null()
     #[inline]
     #[allow(clippy::self_named_constructors)]
     pub fn null() -> Self {

test/src/test_serde.rs

@@ -41,8 +41,8 @@ struct Foo {
     xform: Transform,
     color: Color,
     path: NodePath,
-    // dict: Dictionary, //TODO: PartialEq
-    // v_arr: VariantArray, //TODO: PartialEq
+    // dict: Dictionary, //TODO(#990): PartialEq
+    // v_arr: VariantArray, //TODO(#990): PartialEq
     byte_arr: ByteArray,
     int_arr: Int32Array,
     float_arr: Float32Array,