Appease clippy

Author: chitoyuu

gdnative-core/src/core_types/byte_array.rs

@@ -14,7 +14,7 @@ godot_test!(
         let original_read = {
             let read = arr.read();
             assert_eq!(&[0, 1, 2, 3, 4, 5, 6, 7], read.as_slice());
-            read.clone()
+            read
         };
 
         let mut cow_arr = arr.new_ref();

gdnative-core/src/core_types/color_array.rs

@@ -23,7 +23,7 @@ godot_test!(
                 Color::from_rgb(0.0, 1.0, 0.0),
                 Color::from_rgb(0.0, 0.0, 1.0),
             ], read.as_slice());
-            read.clone()
+            read
         };
 
         let mut cow_arr = arr.new_ref();

gdnative-core/src/core_types/error.rs

@@ -1,6 +1,7 @@
 use crate::sys;
 
 /// Error codes used in various Godot APIs.
+#[allow(clippy::unnecessary_cast)] // False positives: casts necessary for cross-platform
 #[derive(Copy, Clone, Debug, PartialEq, Eq)]
 #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
 #[repr(u32)]
@@ -65,6 +66,7 @@ impl GodotError {
     /// `err` should be a valid value for `GodotError`.
     #[inline]
     #[doc(hidden)]
+    #[allow(clippy::unnecessary_cast)] // False positives: casts necessary for cross-platform
     pub unsafe fn result_from_sys(err: sys::godot_error) -> Result<(), Self> {
         if err == sys::godot_error_GODOT_OK {
             return Ok(());

gdnative-core/src/core_types/float32_array.rs

@@ -16,7 +16,7 @@ godot_test!(
             for (n, i) in read.as_slice().iter().enumerate() {
                 assert_relative_eq!(n as f32, i);
             }
-            read.clone()
+            read
         };
 
         let mut cow_arr = arr.new_ref();
@@ -30,7 +30,7 @@ godot_test!(
         }
 
         for i in 0..8 {
-            assert_relative_eq!(i as f32 * 2., cow_arr.get(i as i32));
+            assert_relative_eq!(i as f32 * 2., cow_arr.get(i));
         }
 
         // the write shouldn't have affected the original array

gdnative-core/src/core_types/int32_array.rs

@@ -14,7 +14,7 @@ godot_test!(
         let original_read = {
             let read = arr.read();
             assert_eq!(&[0, 1, 2, 3, 4, 5, 6, 7], read.as_slice());
-            read.clone()
+            read
         };
 
         let mut cow_arr = arr.new_ref();
@@ -28,7 +28,7 @@ godot_test!(
         }
 
         for i in 0..8 {
-            assert_eq!(i * 2, cow_arr.get(i as i32));
+            assert_eq!(i * 2, cow_arr.get(i));
         }
 
         // the write shouldn't have affected the original array

gdnative-core/src/core_types/string_array.rs

@@ -23,7 +23,7 @@ godot_test!(
                 GodotString::from("bar"),
                 GodotString::from("baz"),
             ], read.as_slice());
-            read.clone()
+            read
         };
 
         let mut cow_arr = arr.new_ref();

gdnative-core/src/core_types/variant.rs

@@ -166,6 +166,7 @@ decl_variant_type!(
 );
 
 impl VariantType {
+    #[allow(clippy::unnecessary_cast)] // False positives: casts necessary for cross-platform
     #[doc(hidden)]
     #[inline]
     pub fn from_sys(v: sys::godot_variant_type) -> VariantType {
@@ -182,6 +183,7 @@ impl VariantType {
     }
 }
 
+#[allow(clippy::unnecessary_cast)] // False positives: casts necessary for cross-platform
 #[repr(u32)]
 #[derive(Copy, Clone, Debug, PartialEq, Eq, Hash)]
 pub enum CallError {
@@ -198,6 +200,7 @@ pub enum CallError {
 }
 
 impl CallError {
+    #[allow(clippy::unnecessary_cast)] // False positives: casts necessary for cross-platform
     #[inline]
     fn from_sys(v: sys::godot_variant_call_error_error) -> Result<(), CallError> {
         if v == sys::godot_variant_call_error_error_GODOT_CALL_ERROR_CALL_OK {
@@ -230,6 +233,7 @@ impl std::fmt::Display for CallError {
 impl std::error::Error for CallError {}
 
 /// Godot variant operator kind.
+#[allow(clippy::unnecessary_cast)] // False positives: casts necessary for cross-platform
 #[repr(u32)]
 #[derive(Copy, Clone, Debug, PartialEq, Eq, Hash)]
 pub enum VariantOperator {
@@ -269,6 +273,7 @@ pub enum VariantOperator {
     In = sys::godot_variant_operator_GODOT_VARIANT_OP_IN as u32,
 }
 
+#[allow(clippy::unnecessary_cast)] // False positives: casts necessary for cross-platform
 impl VariantOperator {
     const MAX: u32 = sys::godot_variant_operator_GODOT_VARIANT_OP_MAX as u32;
 

gdnative-core/src/core_types/vector2_array.rs

@@ -23,7 +23,7 @@ godot_test!(
                 Vector2::new(3.0, 4.0),
                 Vector2::new(5.0, 6.0),
             ], read.as_slice());
-            read.clone()
+            read
         };
 
         let mut cow_arr = arr.new_ref();

gdnative-core/src/core_types/vector3.rs

@@ -15,6 +15,7 @@ pub struct Vector3 {
     pub z: f32,
 }
 
+#[allow(clippy::unnecessary_cast)] // False positives: casts necessary for cross-platform
 #[derive(Copy, Clone, Debug, PartialEq, Eq)]
 #[repr(u32)]
 pub enum Axis {

gdnative-core/src/core_types/vector3_array.rs

@@ -23,7 +23,7 @@ godot_test!(
                 Vector3::new(3.0, 4.0, 5.0),
                 Vector3::new(5.0, 6.0, 7.0),
             ], read.as_slice());
-            read.clone()
+            read
         };
 
         let mut cow_arr = arr.new_ref();