Add CI checks for required error messages.

Author: chitoyuu

.github/composite/godot/action.yml

@@ -62,23 +62,27 @@ runs:
         cd test;
         mkdir -p ./project/lib;
         cp ../target/debug/libgdnative_test.so ./project/lib/;
-        ${GODOT_BIN} --path ./project/ > >(tee "${{ runner.temp }}/stdout.log");
-        if grep -q "Leaked instance" "${{ runner.temp }}/stdout.log"; then
+        ${GODOT_BIN} --path ./project/ > >(tee "${{ runner.temp }}/stdout.log") 2> >(tee "${{ runner.temp }}/stderr.log");
+        bash ../tools/check-test-output.sh "${{ runner.temp }}/stdout.log" "${{ runner.temp }}/stderr.log";
+        if [[ $? -ne 0 ]]; then
           exit 1;
         fi;
-        ${GODOT_BIN} -e --path ./project/ --run-editor-tests > >(tee "${{ runner.temp }}/stdout.log");
-        if grep -q "Leaked instance" "${{ runner.temp }}/stdout.log"; then
+        ${GODOT_BIN} -e --path ./project/ --run-editor-tests > >(tee "${{ runner.temp }}/stdout.log") 2> >(tee "${{ runner.temp }}/stderr.log");
+        bash ../tools/check-test-output.sh "${{ runner.temp }}/stdout.log" "${{ runner.temp }}/stderr.log";
+        if [[ $? -ne 0 ]]; then
           exit 1;
         fi;
         cargo build --features type-tag-fallback ${{ inputs.rust_extra_args }}
         mkdir -p ./project/lib;
         cp ../target/debug/libgdnative_test.so ./project/lib/;
-        ${GODOT_BIN} --path ./project/ > >(tee "${{ runner.temp }}/stdout.log");
-        if grep -q "Leaked instance" "${{ runner.temp }}/stdout.log"; then
+        ${GODOT_BIN} --path ./project/ > >(tee "${{ runner.temp }}/stdout.log") 2> >(tee "${{ runner.temp }}/stderr.log");
+        bash ../tools/check-test-output.sh "${{ runner.temp }}/stdout.log" "${{ runner.temp }}/stderr.log";
+        if [[ $? -ne 0 ]]; then
           exit 1;
         fi;
-        ${GODOT_BIN} -e --path ./project/ --run-editor-tests > >(tee "${{ runner.temp }}/stdout.log");
-        if grep -q "Leaked instance" "${{ runner.temp }}/stdout.log"; then
+        ${GODOT_BIN} -e --path ./project/ --run-editor-tests > >(tee "${{ runner.temp }}/stdout.log") 2> >(tee "${{ runner.temp }}/stderr.log");
+        bash ../tools/check-test-output.sh "${{ runner.temp }}/stdout.log" "${{ runner.temp }}/stderr.log";
+        if [[ $? -ne 0 ]]; then
           exit 1;
         fi;
       shell: bash

tools/check-test-output.sh

@@ -0,0 +1,24 @@
+#!/usr/bin/bash
+
+# Look for required error messages and leaked instances in the outputs of the integration test
+# Usage: check-test-output.sh stdout.log stderr.log
+
+FAIL=0
+
+while read COUNT && read PATTERN; do
+    ACTUAL="$(grep -c "$PATTERN" "$2")"
+    if [[ $? -ne 0 ]]; then
+        ACTUAL=0
+    fi
+    if [[ COUNT -ne ACTUAL ]]; then
+        FAIL=1
+        echo "Found ${ACTUAL} out of ${COUNT} expected instances of message ${PATTERN}"
+    fi
+done < <(sed -e 's/^#.*//' -e '/^$/d' -e 's/^\([0-9]\+\),/\1\n/' -e 's/\\/\\\\/g' "${BASH_SOURCE%/*}/required-errors.txt")
+
+if grep -q "Leaked instance" "$1"; then
+  echo Leaked instances found.
+  FAIL=1
+fi
+
+exit $FAIL

tools/required-errors.txt

@@ -0,0 +1,14 @@
+# Error messages that must be found in the output of the integration test, in the format:
+# <copies>,<grep pattern>
+
+# Empty lines or lines that start with '#' are ignored.
+
+# test_array_debug
+4,thread '[^']*' panicked at 'Index 3 out of bounds (len 3)'
+
+# test_derive_nativeclass_property_with_only_getter
+1,ERROR: \(<unset>: \)\?property size on native class MyVec does not have a setter
+
+# _test_optional_args
+1,ERROR: \(OptionalArgs :: opt_sum: \)\?missing non-optional parameter `b` (#1)
+1,ERROR: \(OptionalArgs :: opt_sum: \)\?an excessive argument is given: I64(6)