Callable::from_object_method() now accepts Gd parameter by shared-ref

Author: Bromeon

examples/dodge-the-creeps/rust/src/main_scene.rs

@@ -105,10 +105,7 @@ impl Main {
         mob.set_linear_velocity(lin_vel);
 
         let mut hud = self.base.get_node_as::<Hud>("Hud");
-        hud.connect(
-            "start_game".into(),
-            Callable::from_object_method(mob, "on_start_game"),
-        );
+        hud.connect("start_game".into(), mob.callable("on_start_game"));
     }
 
     fn music(&mut self) -> &mut AudioStreamPlayer {

godot-core/src/builtin/callable.rs

@@ -35,8 +35,10 @@ impl Callable {
 
     /// Create a callable for the method `object::method_name`.
     ///
+    /// See also [`Gd::callable()`].
+    ///
     /// _Godot equivalent: `Callable(Object object, StringName method)`_
-    pub fn from_object_method<T, S>(object: Gd<T>, method_name: S) -> Self
+    pub fn from_object_method<T, S>(object: &Gd<T>, method_name: S) -> Self
     where
         T: GodotClass, // + Inherits<Object>,
         S: Into<StringName>,

godot-core/src/obj/gd.rs

@@ -385,9 +385,12 @@ impl<T: GodotClass> Gd<T> {
     pub(crate) fn obj_sys(&self) -> sys::GDExtensionObjectPtr {
         self.raw.obj_sys()
     }
+
     /// Returns a callable referencing a method from this object named `method_name`.
+    ///
+    /// This is shorter syntax for [`Callable::from_object_method(self, method_name)`][Callable::from_object_method].
     pub fn callable<S: Into<StringName>>(&self, method_name: S) -> Callable {
-        Callable::from_object_method(self.clone(), method_name)
+        Callable::from_object_method(self, method_name)
     }
 }
 

itest/rust/src/builtin_tests/containers/callable_test.rs

@@ -110,7 +110,7 @@ fn callable_call_return() {
 #[itest]
 fn callable_call_engine() {
     let obj = Node2D::new_alloc();
-    let cb = Callable::from_object_method(obj.clone(), "set_position");
+    let cb = Callable::from_object_method(&obj, "set_position");
     let inner: InnerCallable = cb.as_inner();
 
     assert!(!inner.is_null());