in function MySQLDriver.Open: replace errBadConnNoWrite with driver.ErrBadConn for resend while 'bad connection' happenning

安佳玮 · 安佳玮 · commit c07f37bd144d · 2018-10-19T15:29:47.000+08:00
diff --git a/driver.go b/driver.go
@@ -123,7 +123,8 @@ func (d MySQLDriver) Open(dsn string) (driver.Conn, error) {
 	}
 	if err = mc.writeHandshakeResponsePacket(authResp, addNUL, plugin); err != nil {
 		mc.cleanup()
-		return nil, err
+		// errBadConnNoWrite should be replaced with driver.ErrBadConn for resend
+		return nil, mc.markBadConn(err)
 	}
 
 	// Handle response to auth packet, switch methods if possible

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,8 @@ func (d MySQLDriver) Open(dsn string) (driver.Conn, error) {`
`123`	`123`	`}`
`124`	`124`	`if err = mc.writeHandshakeResponsePacket(authResp, addNUL, plugin); err != nil {`
`125`	`125`	`mc.cleanup()`
`126`		`- return nil, err`
	`126`	`+ // errBadConnNoWrite should be replaced with driver.ErrBadConn for resend`
	`127`	`+ return nil, mc.markBadConn(err)`
`127`	`128`	`}`
`128`	`129`
`129`	`130`	`// Handle response to auth packet, switch methods if possible`