Skip to content

Commit 926cdca

Browse files
committed
Drop go 1.14 support
1 parent 19e8205 commit 926cdca

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ jobs:
1414
strategy:
1515
matrix:
1616
go:
17-
- ^1.14
1817
- ^1.15
1918
- ^1.16
19+
- ^1.17
2020
- ^1
2121
steps:
2222

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Gray components are optional or alternative
2020
- [x] [carbonzipper](https://github.com/go-graphite/carbonzipper) (DEPRECATED, is part of carbonapi currently)
2121

2222
## Build
23-
Required golang 1.13+
23+
Required golang 1.15+
2424
```sh
2525
# build binary
2626
git clone https://github.com/lomik/graphite-clickhouse.git

helper/clickhouse/external-data.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,11 +132,7 @@ func (e *ExternalData) debugDump(ctx context.Context, u url.URL) {
132132
q["query_id"] = []string{fmt.Sprintf("%v:debug", requestID)}
133133
u.RawQuery = q.Encode()
134134

135-
// TODO: replace with u.Redacted() after support of 1.14 is dropped
136-
if _, has := u.User.Password(); has {
137-
u.User = url.UserPassword(u.User.Username(), "xxxxx")
138-
}
139-
command += "'" + u.String() + "'"
135+
command += "'" + u.Redacted() + "'"
140136

141137
logger.Info("external-data", zap.String("debug command", command))
142138
}

0 commit comments

Comments
 (0)